From: James Bottomley <jbottomley@parallels.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: "wenxiong@linux.vnet.ibm.com" <wenxiong@linux.vnet.ibm.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"kbuild@01.org" <kbuild@01.org>, Hiral Patel <hiralpat@cisco.com>
Subject: Re: [scsi:for-next 12/27] drivers/scsi/ipr.c:6568 ipr_qc_issue() warn: inconsistent returns spin_lock:&ipr_cmd->hrrq->_lock: locked (6562) unlocked (6499,6507,6568)
Date: Thu, 20 Dec 2012 22:52:16 +0000 [thread overview]
Message-ID: <1356043933.8606.39.camel@dabdike.home> (raw)
In-Reply-To: <20121217132403.GO5083@mwanda>
On Mon, 2012-12-17 at 16:24 +0300, Dan Carpenter wrote:
> Hi,
>
> FYI, there are new smatch warnings show up in
>
> tree: git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git for-next
> head: e3ff197a750d2912d0bb2a0161c23c18bad250ad
> commit: e7ef7307d9e2c15802e8ea1da9878e0550ec87bc [12/27] [SCSI] ipr: Reduce lock contention
>
> drivers/scsi/ipr.c:5434 ipr_build_ioadl64() info: why not propagate 'nseg' from scsi_dma_map() instead of (-1)?
> drivers/scsi/ipr.c:5485 ipr_build_ioadl() info: why not propagate 'nseg' from scsi_dma_map() instead of (-1)?
> + drivers/scsi/ipr.c:6568 ipr_qc_issue() warn: inconsistent returns spin_lock:&ipr_cmd->hrrq->_lock: locked (6562) unlocked (6499,6507,6568)
Look, guys, I've got these type of reports on about 50% of the patches
in the misc branch of the SCSI tree. This effectively means I don't
have a tree do do a final pull request on ... unless you'd like to get
off your arses and actually send in some fixes.
James
prev parent reply other threads:[~2012-12-20 22:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-17 13:24 [scsi:for-next 12/27] drivers/scsi/ipr.c:6568 ipr_qc_issue() warn: inconsistent returns spin_lock:&ipr_cmd->hrrq->_lock: locked (6562) unlocked (6499,6507,6568) Dan Carpenter
2012-12-20 22:52 ` James Bottomley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1356043933.8606.39.camel@dabdike.home \
--to=jbottomley@parallels.com \
--cc=dan.carpenter@oracle.com \
--cc=hiralpat@cisco.com \
--cc=kbuild@01.org \
--cc=linux-scsi@vger.kernel.org \
--cc=wenxiong@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).