From: "Ewan D. Milne" <emilne@redhat.com>
To: linux-scsi@vger.kernel.org
Subject: [PATCH RFC 2/9] [SCSI] Generate uevent on sd capacity change
Date: Fri, 18 Jan 2013 11:27:07 -0500 [thread overview]
Message-ID: <1358526434-1173-3-git-send-email-emilne@redhat.com> (raw)
In-Reply-To: <1358526434-1173-1-git-send-email-emilne@redhat.com>
From: "Ewan D. Milne" <emilne@redhat.com>
In sd_read_capacity(), detect if the capacity is different from the
previously read value, and generate a uevent if this is the case.
Signed-off-by: Ewan D. Milne <emilne@redhat.com>
---
drivers/scsi/scsi_lib.c | 5 ++++-
drivers/scsi/scsi_sysfs.c | 2 ++
drivers/scsi/sd.c | 9 +++++++++
include/scsi/scsi_device.h | 3 ++-
4 files changed, 17 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c
index 6dfb978..eba68de 100644
--- a/drivers/scsi/scsi_lib.c
+++ b/drivers/scsi/scsi_lib.c
@@ -2186,7 +2186,9 @@ static void scsi_evt_emit(struct scsi_device *sdev, struct scsi_event *evt)
case SDEV_EVT_MEDIA_CHANGE:
envp[idx++] = "SDEV_MEDIA_CHANGE=1";
break;
-
+ case SDEV_EVT_CAPACITY_CHANGE:
+ envp[idx++] = "SDEV_CAPACITY_CHANGE=1";
+ break;
default:
/* do nothing */
break;
@@ -2280,6 +2282,7 @@ struct scsi_event *sdev_evt_alloc(enum scsi_device_event evt_type,
/* evt_type-specific initialization, if any */
switch (evt_type) {
case SDEV_EVT_MEDIA_CHANGE:
+ case SDEV_EVT_CAPACITY_CHANGE:
default:
/* do nothing */
break;
diff --git a/drivers/scsi/scsi_sysfs.c b/drivers/scsi/scsi_sysfs.c
index 04c2a27..ba7da3b 100644
--- a/drivers/scsi/scsi_sysfs.c
+++ b/drivers/scsi/scsi_sysfs.c
@@ -712,6 +712,7 @@ sdev_store_evt_##name(struct device *dev, struct device_attribute *attr,\
#define REF_EVT(name) &dev_attr_evt_##name.attr
DECLARE_EVT(media_change, MEDIA_CHANGE)
+DECLARE_EVT(capacity_change, CAPACITY_CHANGE)
/* Default template for device attributes. May NOT be modified */
static struct attribute *scsi_sdev_attrs[] = {
@@ -731,6 +732,7 @@ static struct attribute *scsi_sdev_attrs[] = {
&dev_attr_ioerr_cnt.attr,
&dev_attr_modalias.attr,
REF_EVT(media_change),
+ REF_EVT(capacity_change),
NULL
};
diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
index 6f0a4c6..9f2d00a 100644
--- a/drivers/scsi/sd.c
+++ b/drivers/scsi/sd.c
@@ -2017,6 +2017,15 @@ got_data:
"%u-byte physical blocks\n",
sdkp->physical_block_size);
}
+
+ /*
+ * Don't report a capacity change event unless we have a
+ * valid "old" value.
+ */
+ if (!sdkp->first_scan && (old_capacity != 0) &&
+ (old_capacity != sdkp->capacity))
+ sdev_evt_send_simple(sdp, SDEV_EVT_CAPACITY_CHANGE,
+ GFP_KERNEL);
}
/* Rescale capacity to 512-byte units */
diff --git a/include/scsi/scsi_device.h b/include/scsi/scsi_device.h
index 6efb2e1..e4c964e 100644
--- a/include/scsi/scsi_device.h
+++ b/include/scsi/scsi_device.h
@@ -51,8 +51,9 @@ enum scsi_device_state {
enum scsi_device_event {
SDEV_EVT_MEDIA_CHANGE = 1, /* media has changed */
+ SDEV_EVT_CAPACITY_CHANGE = 2, /* capacity has changed */
- SDEV_EVT_LAST = SDEV_EVT_MEDIA_CHANGE,
+ SDEV_EVT_LAST = SDEV_EVT_CAPACITY_CHANGE,
SDEV_EVT_MAXBITS = SDEV_EVT_LAST + 1
};
--
1.7.11.7
next prev parent reply other threads:[~2013-01-18 16:27 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-18 16:27 [PATCH RFC 0/9] [SCSI] Enhanced sense and Unit Attention handling Ewan D. Milne
2013-01-18 16:27 ` [PATCH RFC 1/9] [SCSI] Detect overflow of sense data buffer Ewan D. Milne
2013-01-18 16:46 ` James Bottomley
2013-01-21 7:26 ` Hannes Reinecke
2013-01-21 8:58 ` James Bottomley
2013-01-21 17:42 ` Douglas Gilbert
2013-01-22 15:10 ` Ewan Milne
2013-01-23 7:16 ` Hannes Reinecke
2013-01-22 15:08 ` Ewan Milne
2013-01-23 10:44 ` Hannes Reinecke
2013-01-23 13:06 ` James Bottomley
2013-01-23 21:21 ` Ewan Milne
2013-01-18 16:27 ` Ewan D. Milne [this message]
2013-01-18 16:27 ` [PATCH RFC 3/9] [SCSI] Add a kernel config option for enhanced Unit Attention support Ewan D. Milne
2013-01-18 16:27 ` [PATCH RFC 4/9] [SCSI] Rename scsi_evt_xxx to sdev_evt_xxx and scsi_event to sdev_event Ewan D. Milne
2013-01-22 17:33 ` Bart Van Assche
2013-01-23 21:08 ` Ewan Milne
2013-01-22 17:38 ` Bart Van Assche
2013-01-23 20:39 ` Ewan Milne
2013-01-18 16:27 ` [PATCH RFC 5/9] [SCSI] Add support for scsi_target events Ewan D. Milne
2013-01-18 16:27 ` [PATCH RFC 6/9] [SCSI] Generate uevents for certain Unit Attention codes Ewan D. Milne
2013-01-18 16:27 ` [PATCH RFC 7/9] [SCSI] Add sysfs support for enhanced Unit Attention handling Ewan D. Milne
2013-01-18 16:27 ` [PATCH RFC 8/9] [SCSI] Add sense and Unit Attention generation to scsi_debug Ewan D. Milne
2013-01-19 18:43 ` Douglas Gilbert
2013-01-22 15:12 ` Ewan Milne
2013-01-18 16:27 ` [PATCH RFC 9/9] [SCSI] Streamline detection of FM/EOM/ILI status Ewan D. Milne
2013-01-24 0:19 ` [PATCH RFC 0/9] [SCSI] Enhanced sense and Unit Attention handling Bart Van Assche
2013-01-24 11:38 ` Hannes Reinecke
2013-01-24 14:00 ` Ewan Milne
2013-01-24 14:01 ` Mike Christie
2013-01-24 22:02 ` Ewan Milne
2013-01-24 22:47 ` Mike Christie
2013-01-24 14:38 ` Bart Van Assche
2013-01-24 14:51 ` Hannes Reinecke
2013-01-24 15:00 ` Mike Christie
2013-01-24 15:15 ` Hannes Reinecke
2013-01-24 22:00 ` Ewan Milne
2013-01-26 18:20 ` Mike Christie
2013-01-28 6:56 ` Hannes Reinecke
2013-01-28 15:05 ` Jeremy Linton
2013-01-28 15:44 ` Bart Van Assche
2013-01-28 15:48 ` Hannes Reinecke
2013-01-28 20:26 ` James Bottomley
2013-01-28 15:52 ` Jeremy Linton
2013-01-28 16:04 ` Ewan Milne
2013-01-28 16:18 ` Mike Christie
2013-01-29 5:01 ` Shyam_Iyer
2013-01-24 13:53 ` Ewan Milne
2013-01-31 16:27 ` Ewan Milne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1358526434-1173-3-git-send-email-emilne@redhat.com \
--to=emilne@redhat.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).