From mboxrd@z Thu Jan 1 00:00:00 1970 From: Masatake YAMATO Subject: [RESEND PATCH] libiscsi: avoid unnecessary multiple NULL assignments Date: Wed, 23 Jan 2013 17:05:46 +0900 Message-ID: <1358928346-3399-1-git-send-email-yamato@redhat.com> Return-path: Received: from h219-110-094-192.catv01.itscom.jp ([219.110.94.192]:51153 "EHLO localhost.localdomain" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751163Ab3AWSlO (ORCPT ); Wed, 23 Jan 2013 13:41:14 -0500 Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: linux-scsi@vger.kernel.org Cc: Masatake YAMATO In iscsi_free_task, NULL is assigned to task->sc twice: before and after kfifo_in invocatoin. Allocating and freeing iscsi_task are guarded with session->lock, so multiple NULL assignments cause no trouble. But people reading the source code may be confused. The second NULL assignment comes from commit: 3e5c28ad0391389959ccae81c938c7533efb3490 It seems that the line after kfifo_in invocation was introduced accidentally. Signed-off-by: Masatake YAMATO Reviewed-by: Mike Christie --- drivers/scsi/libiscsi.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/scsi/libiscsi.c b/drivers/scsi/libiscsi.c index 82c3fd4..7aacf3a 100644 --- a/drivers/scsi/libiscsi.c +++ b/drivers/scsi/libiscsi.c @@ -507,7 +507,6 @@ static void iscsi_free_task(struct iscsi_task *task) kfifo_in(&session->cmdpool.queue, (void*)&task, sizeof(void*)); if (sc) { - task->sc = NULL; /* SCSI eh reuses commands to verify us */ sc->SCp.ptr = NULL; /* -- 1.7.11.7