From: Ewan Milne <emilne@redhat.com>
To: Bart Van Assche <bart.vanassche@gmail.com>
Cc: linux-scsi@vger.kernel.org
Subject: Re: [PATCH RFC 4/9] [SCSI] Rename scsi_evt_xxx to sdev_evt_xxx and scsi_event to sdev_event
Date: Wed, 23 Jan 2013 16:08:51 -0500 [thread overview]
Message-ID: <1358975331.4420.370.camel@localhost.localdomain> (raw)
In-Reply-To: <CAO+b5-qvyoSA1fSjZC-LLMPmzDUKhoCQTRCvxBe1+u3BgjYMpg@mail.gmail.com>
On Tue, 2013-01-22 at 10:33 -0700, Bart Van Assche wrote:
> On Fri, Jan 18, 2013 at 9:27 AM, Ewan D. Milne <emilne@redhat.com> wrote:
> >
> > @@ -2206,7 +2206,7 @@ static void scsi_evt_emit(struct scsi_device *sdev, struct scsi_event *evt)
> > * Dispatch queued events to their associated scsi_device kobjects
> > * as uevents.
> > */
> > -void scsi_evt_thread(struct work_struct *work)
> > +void sdev_evt_thread(struct work_struct *work)
> > {
> > struct scsi_device *sdev;
> > LIST_HEAD(event_list);
>
> This code does not run as a long-living thread so please consider
> using the name "sdev_evt_work" instead.
Good idea. I'll do that.
>
> Bart.
next prev parent reply other threads:[~2013-01-23 21:08 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-18 16:27 [PATCH RFC 0/9] [SCSI] Enhanced sense and Unit Attention handling Ewan D. Milne
2013-01-18 16:27 ` [PATCH RFC 1/9] [SCSI] Detect overflow of sense data buffer Ewan D. Milne
2013-01-18 16:46 ` James Bottomley
2013-01-21 7:26 ` Hannes Reinecke
2013-01-21 8:58 ` James Bottomley
2013-01-21 17:42 ` Douglas Gilbert
2013-01-22 15:10 ` Ewan Milne
2013-01-23 7:16 ` Hannes Reinecke
2013-01-22 15:08 ` Ewan Milne
2013-01-23 10:44 ` Hannes Reinecke
2013-01-23 13:06 ` James Bottomley
2013-01-23 21:21 ` Ewan Milne
2013-01-18 16:27 ` [PATCH RFC 2/9] [SCSI] Generate uevent on sd capacity change Ewan D. Milne
2013-01-18 16:27 ` [PATCH RFC 3/9] [SCSI] Add a kernel config option for enhanced Unit Attention support Ewan D. Milne
2013-01-18 16:27 ` [PATCH RFC 4/9] [SCSI] Rename scsi_evt_xxx to sdev_evt_xxx and scsi_event to sdev_event Ewan D. Milne
2013-01-22 17:33 ` Bart Van Assche
2013-01-23 21:08 ` Ewan Milne [this message]
2013-01-22 17:38 ` Bart Van Assche
2013-01-23 20:39 ` Ewan Milne
2013-01-18 16:27 ` [PATCH RFC 5/9] [SCSI] Add support for scsi_target events Ewan D. Milne
2013-01-18 16:27 ` [PATCH RFC 6/9] [SCSI] Generate uevents for certain Unit Attention codes Ewan D. Milne
2013-01-18 16:27 ` [PATCH RFC 7/9] [SCSI] Add sysfs support for enhanced Unit Attention handling Ewan D. Milne
2013-01-18 16:27 ` [PATCH RFC 8/9] [SCSI] Add sense and Unit Attention generation to scsi_debug Ewan D. Milne
2013-01-19 18:43 ` Douglas Gilbert
2013-01-22 15:12 ` Ewan Milne
2013-01-18 16:27 ` [PATCH RFC 9/9] [SCSI] Streamline detection of FM/EOM/ILI status Ewan D. Milne
2013-01-24 0:19 ` [PATCH RFC 0/9] [SCSI] Enhanced sense and Unit Attention handling Bart Van Assche
2013-01-24 11:38 ` Hannes Reinecke
2013-01-24 14:00 ` Ewan Milne
2013-01-24 14:01 ` Mike Christie
2013-01-24 22:02 ` Ewan Milne
2013-01-24 22:47 ` Mike Christie
2013-01-24 14:38 ` Bart Van Assche
2013-01-24 14:51 ` Hannes Reinecke
2013-01-24 15:00 ` Mike Christie
2013-01-24 15:15 ` Hannes Reinecke
2013-01-24 22:00 ` Ewan Milne
2013-01-26 18:20 ` Mike Christie
2013-01-28 6:56 ` Hannes Reinecke
2013-01-28 15:05 ` Jeremy Linton
2013-01-28 15:44 ` Bart Van Assche
2013-01-28 15:48 ` Hannes Reinecke
2013-01-28 20:26 ` James Bottomley
2013-01-28 15:52 ` Jeremy Linton
2013-01-28 16:04 ` Ewan Milne
2013-01-28 16:18 ` Mike Christie
2013-01-29 5:01 ` Shyam_Iyer
2013-01-24 13:53 ` Ewan Milne
2013-01-31 16:27 ` Ewan Milne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1358975331.4420.370.camel@localhost.localdomain \
--to=emilne@redhat.com \
--cc=bart.vanassche@gmail.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).