From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: kbuild test robot <fengguang.wu@intel.com>
Cc: Chad Dupuis <chad.dupuis@qlogic.com>,
linux-scsi@vger.kernel.org,
Saurav Kashyap <saurav.kashyap@qlogic.com>
Subject: Re: [scsi:for-next 14/27] drivers/scsi/qla2xxx/qla_os.c:364 qla2x00_free_req_que() info: redundant null check on req->outstanding_cmds calling kfree()
Date: Tue, 29 Jan 2013 13:59:37 +1100 [thread overview]
Message-ID: <1359428377.2408.20.camel@dabdike> (raw)
In-Reply-To: <50cf1402.D18vi8fJJPt89aXx%fengguang.wu@intel.com>
On Mon, 2012-12-17 at 20:45 +0800, kbuild test robot wrote:
> tree: git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git for-next
> head: e3ff197a750d2912d0bb2a0161c23c18bad250ad
> commit: 99cc149bbdd78a3f18c6b366e1c239f62d59d096 [14/27] [SCSI] qla2xxx: Determine the number of outstanding commands based on available resources.
>
>
> smatch warnings:
>
> + drivers/scsi/qla2xxx/qla_os.c:364 qla2x00_free_req_que() info: redundant null check on req->outstanding_cmds calling kfree()
> drivers/scsi/qla2xxx/qla_os.c:686 qla2xxx_queuecommand() error: potential NULL dereference 'rport'.
I flushed all the outstanding qla2xxx patches from the SCSI tree.
Please fix these issues and resubmit.
Thanks,
James
next prev parent reply other threads:[~2013-01-29 2:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-17 12:45 [scsi:for-next 14/27] drivers/scsi/qla2xxx/qla_os.c:364 qla2x00_free_req_que() info: redundant null check on req->outstanding_cmds calling kfree() kbuild test robot
2013-01-29 2:59 ` James Bottomley [this message]
2013-01-30 5:25 ` Saurav Kashyap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1359428377.2408.20.camel@dabdike \
--to=james.bottomley@hansenpartnership.com \
--cc=chad.dupuis@qlogic.com \
--cc=fengguang.wu@intel.com \
--cc=linux-scsi@vger.kernel.org \
--cc=saurav.kashyap@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox