From: James Bottomley <jbottomley@parallels.com>
To: Hannes Reinecke <hare@suse.de>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
Steffen Maier <maier@linux.vnet.ibm.com>,
James Smart <james.smart@emulex.com>,
Andrew Vasquez <andrew.vasquez@qlogic.com>,
Krishna Gudipati <kgudipat@brocade.com>,
Jayamohan Kallickal <jayamohan.kallickal@emulex.com>,
Abhijeet Joglekar <abjoglek@cisco.com>
Subject: Re: [PATCH] scsi: Allow 64-bit LUNs during report lun scan
Date: Thu, 14 Feb 2013 03:37:09 +0000 [thread overview]
Message-ID: <1360813027.2502.7.camel@dabdike> (raw)
In-Reply-To: <1360767971-947-1-git-send-email-hare@suse.de>
On Wed, 2013-02-13 at 16:06 +0100, Hannes Reinecke wrote:
> shost->max_lun is only ever useful when doing a sequential
> scan as we need to limit the number of devices to scan there.
> For report lun scan we should allow _any_ reported LUN number
> as long as the LLDD supports 64 bit LUNs.
>
> So add a new flag 'support_64bit_luns' to the scsi host and
> modify report lun scan to not check for max_luns during
> scanning if that flag is set. This will get rid of the
> annoying 'lunXXXX has a LUN larger than allowed ...'
> message and allow scanning to continue.
What advantage does this have over setting max_lun to ~0?
Plus, if we're going to advertise 64 bit lun support I'd rather have us
be actually capable of it ... luns are handled as 32 bit numbers in the
mid layer currently.
James
next prev parent reply other threads:[~2013-02-14 3:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-13 15:06 [PATCH] scsi: Allow 64-bit LUNs during report lun scan Hannes Reinecke
2013-02-13 19:52 ` Jeremy Linton
2013-02-13 20:21 ` Bart Van Assche
2013-02-14 3:38 ` James Bottomley
2013-02-14 18:02 ` Jeremy Linton
2013-02-14 22:04 ` Elliott, Robert (Server Storage)
2013-02-14 22:38 ` Jeremy Linton
2013-02-14 22:44 ` Jeremy Linton
2013-02-15 7:26 ` Hannes Reinecke
2013-02-15 7:33 ` Bart Van Assche
2013-02-15 7:15 ` Hannes Reinecke
2013-02-14 3:37 ` James Bottomley [this message]
2013-02-14 21:21 ` Jeremy Linton
2013-02-15 16:25 ` Jeremy Linton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1360813027.2502.7.camel@dabdike \
--to=jbottomley@parallels.com \
--cc=abjoglek@cisco.com \
--cc=andrew.vasquez@qlogic.com \
--cc=hare@suse.de \
--cc=james.smart@emulex.com \
--cc=jayamohan.kallickal@emulex.com \
--cc=kgudipat@brocade.com \
--cc=linux-scsi@vger.kernel.org \
--cc=maier@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).