Re: Kernel oops on st module cycling

Jean Delvare
2013-03-07T12:48:00Z

Hi Joe,

Thanks for your fast answer.

Le vendredi 22 février 2013 à 10:30 -0500, Joe Lawrence a écrit :
> I remember finding an st module load/unload kref accounting bug a while
> ago: http://thread.gmane.org/gmane.linux.scsi/77539 I replied to the
> report with a hack-patch that grabbed an extra reference to avoid the
> crash.
>
> There was an attempt at fixing this up in the block layer [1] but that
> change was pulled when problems were found with that patch [2].
>
> [1] https://lkml.org/lkml/2012/8/27/354
> [2] https://lkml.org/lkml/2012/9/22/113
>
> Maybe this is the same bug?

Seems so. Meanwhile I saw you posted an update at:
http://marc.info/?l=linux-scsi&m=136249932603011&w=2

I have tested this patch successfully, and apparently others have as
well, so I would suggest to get this upstream ASAP. I think this fix is
a candidate for stable kernel series as well.

Note for backporters: the value returned by blk_get_queue() changed in
kernel 3.3, so care must be taken when backporting the fix to kernel 3.2
or older, otherwise success becomes failure and vice versa.

Thanks,
--
Jean Delvare
Suse L3

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html