public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Rob Evers <revers@redhat.com>
To: linux-scsi@vger.kernel.org
Cc: revers@redhat.com, michaelc@cs.wisc.edu, bvanassche@acm.org,
	emilne@redhat.com
Subject: [PATCH V3 4/4] Use set/get_unaligned_be32 in report_luns
Date: Thu,  7 Mar 2013 08:38:35 -0500	[thread overview]
Message-ID: <1362663515-3476-5-git-send-email-revers@redhat.com> (raw)
In-Reply-To: <1362663515-3476-1-git-send-email-revers@redhat.com>

---
 drivers/scsi/scsi_scan.c | 16 ++++------------
 1 file changed, 4 insertions(+), 12 deletions(-)

diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c
index 1d41730..31bda4b 100644
--- a/drivers/scsi/scsi_scan.c
+++ b/drivers/scsi/scsi_scan.c
@@ -34,6 +34,7 @@
 #include <linux/spinlock.h>
 #include <linux/async.h>
 #include <linux/slab.h>
+#include <asm/unaligned.h>
 
 #include <scsi/scsi.h>
 #include <scsi/scsi_cmnd.h>
@@ -1301,10 +1302,7 @@ int scsi_do_report_luns(struct scsi_device *sdev, int length,
 	/*
 	 * bytes 6 - 9: length of the command.
 	 */
-	scsi_cmd[6] = (unsigned char) (length >> 24) & 0xff;
-	scsi_cmd[7] = (unsigned char) (length >> 16) & 0xff;
-	scsi_cmd[8] = (unsigned char) (length >> 8) & 0xff;
-	scsi_cmd[9] = (unsigned char) length & 0xff;
+	put_unaligned_be32(0xffffffff, &scsi_cmd[6]);
 
 	scsi_cmd[10] = 0;	/* reserved */
 	scsi_cmd[11] = 0;	/* control */
@@ -1441,10 +1439,7 @@ static int scsi_report_lun_scan(struct scsi_target *starget, int bflags,
 	/*
 	 * Get the length from the first four bytes of first_lun_data.
 	 */
-	data = (u8 *) first_lun_data->scsi_lun;
-	length = ((data[0] << 24) | (data[1] << 16) |
-		  (data[2] << 8) | (data[3] << 0));
-
+	length = get_unaligned_be32(first_lun_data->scsi_lun);
 	num_luns_reported = (length / sizeof(struct scsi_lun));
 
 	if (num_luns_reported > max_scsi_report_luns) {
@@ -1486,10 +1481,7 @@ static int scsi_report_lun_scan(struct scsi_target *starget, int bflags,
 				 * Get the length from the first four bytes
 				 * of second_lun_data.
 				 */
-				data = (u8 *) lun_data->scsi_lun;
-				length = ((data[0] << 24) | (data[1] << 16) |
-				  (data[2] << 8) | (data[3] << 0));
-
+				length = get_unaligned_be32(lun_data->scsi_lun);
 				num_luns = (length / sizeof(struct scsi_lun));
 			}
 		}
-- 
1.7.11.7


  parent reply	other threads:[~2013-03-07 13:38 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-07 13:38 [PATCH V3 0/4] Configure number of LUs reported by 'report-luns' Rob Evers
2013-03-07 13:38 ` [PATCH V3 1/4] Encapsulate scsi_do_report_luns Rob Evers
2013-03-07 15:47   ` Elliott, Robert (Server Storage)
2013-03-07 16:06     ` Jeremy Linton
2013-03-07 17:01       ` Elliott, Robert (Server Storage)
2013-03-07 17:30         ` James Bottomley
2013-03-07 17:38           ` Elliott, Robert (Server Storage)
2013-03-07 17:48             ` James Bottomley
2013-03-07 17:42           ` Jeremy Linton
2013-03-07 13:38 ` [PATCH V3 2/4] Configure reported luns Rob Evers
2013-03-07 13:38 ` [PATCH V3 3/4] Change kmallocs in report_luns to use GFP_KERNEL Rob Evers
2013-03-07 13:38 ` Rob Evers [this message]
2013-03-07 14:31 ` [PATCH V3 0/4] Configure number of LUs reported by 'report-luns' Ewan Milne
2013-03-07 17:01 ` Rob Evers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1362663515-3476-5-git-send-email-revers@redhat.com \
    --to=revers@redhat.com \
    --cc=bvanassche@acm.org \
    --cc=emilne@redhat.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=michaelc@cs.wisc.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox