From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Zhang Yanfei <zhangyanfei@cn.fujitsu.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-scsi@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 12/18] driver: scsi: remove cast for kmalloc/kzalloc return value
Date: Tue, 12 Mar 2013 09:27:49 +0000 [thread overview]
Message-ID: <1363080469.2401.26.camel@dabdike.int.hansenpartnership.com> (raw)
In-Reply-To: <513EBC2F.6030601@cn.fujitsu.com>
On Tue, 2013-03-12 at 13:25 +0800, Zhang Yanfei wrote:
> remove cast for kmalloc/kzalloc return value.
I've got to ask why? Just because void * can be assigned to any pointer
doesn't mean we should religiously eliminate all casts of void *. If
the driver writer believes there's value making sure of the pointer
type, I'm happy to keep the cast.
James
next prev parent reply other threads:[~2013-03-12 9:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <513EB23D.7020303@cn.fujitsu.com>
2013-03-12 5:25 ` [PATCH 12/18] driver: scsi: remove cast for kmalloc/kzalloc return value Zhang Yanfei
2013-03-12 9:27 ` James Bottomley [this message]
2013-03-12 16:32 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1363080469.2401.26.camel@dabdike.int.hansenpartnership.com \
--to=james.bottomley@hansenpartnership.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=zhangyanfei@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox