From: James Bottomley <jbottomley@parallels.com>
To: kbuild test robot <fengguang.wu@intel.com>
Cc: Giridhar Malavali <giridhar.malavali@qlogic.com>,
Saurav Kashyap <saurav.kashyap@qlogic.com>,
Armen Baloyan <armen.baloyan@qlogic.com>,
Andrew Vazquez <andrew.vasquez@qlogic.com>,
"kbuild-all@01.org" <kbuild-all@01.org>,
linux-scsi <linux-scsi@vger.kernel.org>
Subject: Re: [scsi:misc 46/59] drivers/scsi/qla2xxx/qla_mr.c:3007:7: warning: large integer implicitly truncated to unsigned type
Date: Fri, 12 Apr 2013 18:06:54 +0000 [thread overview]
Message-ID: <1365790013.1934.34.camel@dabdike> (raw)
In-Reply-To: <516764a0.CxAUmlQBEvv7Rtte%fengguang.wu@intel.com>
[linux-scsi cc added]
On Fri, 2013-04-12 at 09:34 +0800, kbuild test robot wrote:
> tree: git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git misc
> head: 9e45dd73234af9a59613dc2989dcc2df2dab847f
> commit: 8ae6d9c7eb1004bc134813287010d57a863ba13b [46/59] [SCSI] qla2xxx: Enhancements to support ISPFx00.
> config: make ARCH=powerpc allmodconfig
>
> All warnings:
>
> drivers/scsi/qla2xxx/qla_mr.c: In function 'qlafx00_build_scsi_iocbs':
> >> drivers/scsi/qla2xxx/qla_mr.c:3007:7: warning: large integer implicitly truncated to unsigned type [-Woverflow]
> >> drivers/scsi/qla2xxx/qla_mr.c:3011:7: warning: large integer implicitly truncated to unsigned type [-Woverflow]
>
> vim +3007 drivers/scsi/qla2xxx/qla_mr.c
>
> 3001 return;
> 3002 }
> 3003
> 3004 /* Set transfer direction */
> 3005 if (cmd->sc_data_direction == DMA_TO_DEVICE) {
> 3006 lcmd_pkt->cntrl_flags =
> > 3007 __constant_cpu_to_le16(TMF_WRITE_DATA);
> 3008 vha->qla_stats.output_bytes += scsi_bufflen(cmd);
> 3009 } else if (cmd->sc_data_direction == DMA_FROM_DEVICE) {
> 3010 lcmd_pkt->cntrl_flags =
> > 3011 __constant_cpu_to_le16(TMF_READ_DATA);
> 3012 vha->qla_stats.input_bytes += scsi_bufflen(cmd);
> 3013 }
> 3014
This is because of this definition in qla_mr.h:
struct cmd_type_7_fx00 {
...
uint8_t cntrl_flags;
Which means that the assignment produces zero on a BE platform. That
doesn't look right. Please fix.
James
next parent reply other threads:[~2013-04-12 18:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <516764a0.CxAUmlQBEvv7Rtte%fengguang.wu@intel.com>
2013-04-12 18:06 ` James Bottomley [this message]
2013-04-12 19:35 ` [scsi:misc 46/59] drivers/scsi/qla2xxx/qla_mr.c:3007:7: warning: large integer implicitly truncated to unsigned type Chad Dupuis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1365790013.1934.34.camel@dabdike \
--to=jbottomley@parallels.com \
--cc=andrew.vasquez@qlogic.com \
--cc=armen.baloyan@qlogic.com \
--cc=fengguang.wu@intel.com \
--cc=giridhar.malavali@qlogic.com \
--cc=kbuild-all@01.org \
--cc=linux-scsi@vger.kernel.org \
--cc=saurav.kashyap@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox