* Re: [scsi:misc 46/59] drivers/scsi/qla2xxx/qla_mr.c:3007:7: warning: large integer implicitly truncated to unsigned type
2013-04-12 18:06 ` [scsi:misc 46/59] drivers/scsi/qla2xxx/qla_mr.c:3007:7: warning: large integer implicitly truncated to unsigned type James Bottomley
@ 2013-04-12 19:35 ` Chad Dupuis
0 siblings, 0 replies; 2+ messages in thread
From: Chad Dupuis @ 2013-04-12 19:35 UTC (permalink / raw)
To: James Bottomley
Cc: kbuild test robot, Giridhar Malavali, Saurav Kashyap,
Armen Baloyan, Andrew Vasquez, kbuild-all@01.org, linux-scsi
On Fri, 12 Apr 2013, James Bottomley wrote:
> [linux-scsi cc added]
> On Fri, 2013-04-12 at 09:34 +0800, kbuild test robot wrote:
>> tree: git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git misc
>> head: 9e45dd73234af9a59613dc2989dcc2df2dab847f
>> commit: 8ae6d9c7eb1004bc134813287010d57a863ba13b [46/59] [SCSI] qla2xxx: Enhancements to support ISPFx00.
>> config: make ARCH=powerpc allmodconfig
>>
>> All warnings:
>>
>> drivers/scsi/qla2xxx/qla_mr.c: In function 'qlafx00_build_scsi_iocbs':
>>>> drivers/scsi/qla2xxx/qla_mr.c:3007:7: warning: large integer implicitly truncated to unsigned type [-Woverflow]
>>>> drivers/scsi/qla2xxx/qla_mr.c:3011:7: warning: large integer implicitly truncated to unsigned type [-Woverflow]
>>
>> vim +3007 drivers/scsi/qla2xxx/qla_mr.c
>>
>> 3001 return;
>> 3002 }
>> 3003
>> 3004 /* Set transfer direction */
>> 3005 if (cmd->sc_data_direction == DMA_TO_DEVICE) {
>> 3006 lcmd_pkt->cntrl_flags =
>>> 3007 __constant_cpu_to_le16(TMF_WRITE_DATA);
>> 3008 vha->qla_stats.output_bytes += scsi_bufflen(cmd);
>> 3009 } else if (cmd->sc_data_direction == DMA_FROM_DEVICE) {
>> 3010 lcmd_pkt->cntrl_flags =
>>> 3011 __constant_cpu_to_le16(TMF_READ_DATA);
>> 3012 vha->qla_stats.input_bytes += scsi_bufflen(cmd);
>> 3013 }
>> 3014
>
> This is because of this definition in qla_mr.h:
>
> struct cmd_type_7_fx00 {
> ...
> uint8_t cntrl_flags;
>
> Which means that the assignment produces zero on a BE platform. That
> doesn't look right. Please fix.
>
> James
>
Thanks for the head up James. Will send a fix soon.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
________________________________
This message and any attached documents contain information from QLogic Corporation or its wholly-owned subsidiaries that may be confidential. If you are not the intended recipient, you may not read, copy, distribute, or use this information. If you have received this transmission in error, please notify the sender immediately by reply e-mail and then delete this message.
^ permalink raw reply [flat|nested] 2+ messages in thread