From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
fengguang.wu@intel.com, yokota@netlab.is.tsukuba.ac.jp,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] scsi: pcmcia: nsp_cs: remove module init/exit function prototypes
Date: Mon, 15 Apr 2013 10:20:57 -0700 [thread overview]
Message-ID: <1366046457.6170.1.camel@dabdike> (raw)
In-Reply-To: <201304150942.37837.hsweeten@visionengravers.com>
On Mon, 2013-04-15 at 09:42 -0700, H Hartley Sweeten wrote:
> This driver now uses the module_pcmcia_driver() macro to supply the
> init/exit code. The nsp_cs_{init,exit} prototypes should be removed.
This reasoning is bogus.
Why the driver actually has all these static prototypes in its header
file is entirely unclear to me, but singling these two out for the
reason you state above is wrong (both the reason and picking only two of
them).
Hiroshi, you're the maintainer, what do you want to do ... since the
driver is ancient, I'm happy to leave it untouched, or if you want to
tidy it up, I see no reason to have any static prototypes in the header
file.
Thanks,
James
prev parent reply other threads:[~2013-04-15 17:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-15 16:42 [PATCH] scsi: pcmcia: nsp_cs: remove module init/exit function prototypes H Hartley Sweeten
2013-04-15 17:20 ` James Bottomley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1366046457.6170.1.camel@dabdike \
--to=james.bottomley@hansenpartnership.com \
--cc=fengguang.wu@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hsweeten@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=yokota@netlab.is.tsukuba.ac.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox