From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Bhanu Prakash Gollapudi <bprakash@broadcom.com>
Cc: linux-scsi@vger.kernel.org
Subject: Re: [PATCH 2/5] bnx2fc: Include chip number in the symbolic name
Date: Wed, 01 May 2013 17:39:53 -0700 [thread overview]
Message-ID: <1367455193.26485.0.camel@dabdike> (raw)
In-Reply-To: <1362778134-21045-3-git-send-email-bprakash@broadcom.com>
On Fri, 2013-03-08 at 13:28 -0800, Bhanu Prakash Gollapudi wrote:
> +#ifndef PCI_DEVICE_ID_NX2_57710
> +#define PCI_DEVICE_ID_NX2_57710 0x164e
> +#endif
> +#ifndef PCI_DEVICE_ID_NX2_57711
> +#define PCI_DEVICE_ID_NX2_57711 0x164f
> +#endif
> +#ifndef PCI_DEVICE_ID_NX2_57712
> +#define PCI_DEVICE_ID_NX2_57712 0x1662
> +#endif
> +#ifndef PCI_DEVICE_ID_NX2_57712_MF
> +#define PCI_DEVICE_ID_NX2_57712_MF 0x1663
> +#endif
> +#ifndef PCI_DEVICE_ID_NX2_57712_VF
> +#define PCI_DEVICE_ID_NX2_57712_VF 0x166f
> +#endif
> +#ifndef PCI_DEVICE_ID_NX2_57800
> +#define PCI_DEVICE_ID_NX2_57800 0x168a
> +#endif
> +#ifndef PCI_DEVICE_ID_NX2_57800_MF
> +#define PCI_DEVICE_ID_NX2_57800_MF 0x16a5
> +#endif
> +#ifndef PCI_DEVICE_ID_NX2_57800_VF
> +#define PCI_DEVICE_ID_NX2_57800_VF 0x16a9
> +#endif
> +#ifndef PCI_DEVICE_ID_NX2_57810
> +#define PCI_DEVICE_ID_NX2_57810 0x168e
> +#endif
> +#ifndef PCI_DEVICE_ID_NX2_57810_MF
> +#define PCI_DEVICE_ID_NX2_57810_MF 0x16ae
> +#endif
> +#ifndef PCI_DEVICE_ID_NX2_57810_VF
> +#define PCI_DEVICE_ID_NX2_57810_VF 0x16af
> +#endif
> +#ifndef PCI_DEVICE_ID_NX2_57840
> +#define PCI_DEVICE_ID_NX2_57840 0x168d
> +#endif
> +#ifndef PCI_DEVICE_ID_NX2_57840_MF
> +#define PCI_DEVICE_ID_NX2_57840_MF 0x16a4
> +#endif
> +#ifndef PCI_DEVICE_ID_NX2_57840_VF
> +#define PCI_DEVICE_ID_NX2_57840_VF 0x16ad
> +#endif
> +#ifndef PCI_DEVICE_ID_NX2_57840_2_20
> +#define PCI_DEVICE_ID_NX2_57840_2_20 0x16a2
> +#endif
> +#ifndef PCI_DEVICE_ID_NX2_57840_4_10
> +#define PCI_DEVICE_ID_NX2_57840_4_10 0x16a1
> +#endif
This doesn't belong in your header file. Most of the IDs are already in
pci_ids.h; I added the few which weren't.
James
next prev parent reply other threads:[~2013-05-02 0:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-08 21:28 [PATCH 0/5] bnx2fc version 1.0.14 Bhanu Prakash Gollapudi
2013-03-08 21:28 ` [PATCH 1/5] bnx2fc: Enable cached tasks to improve performance Bhanu Prakash Gollapudi
2013-03-08 21:28 ` [PATCH 2/5] bnx2fc: Include chip number in the symbolic name Bhanu Prakash Gollapudi
2013-05-02 0:39 ` James Bottomley [this message]
2013-05-02 0:42 ` Bhanu Prakash Gollapudi
2013-03-08 21:28 ` [PATCH 3/5] bnx2fc: Fix race condition between IO completion and abort Bhanu Prakash Gollapudi
2013-03-08 21:28 ` [PATCH 4/5] bnx2fc: Update copyright information Bhanu Prakash Gollapudi
2013-03-08 21:28 ` [PATCH 5/5] bnx2fc: Bumped version to 1.0.14 Bhanu Prakash Gollapudi
2013-03-08 23:53 ` Bhanu Prakash Gollapudi
2013-05-02 1:05 ` James Bottomley
2013-05-02 3:05 ` Bhanu Prakash Gollapudi
2013-04-18 21:47 ` [PATCH 0/5] bnx2fc version 1.0.14 Bhanu Prakash Gollapudi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1367455193.26485.0.camel@dabdike \
--to=james.bottomley@hansenpartnership.com \
--cc=bprakash@broadcom.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).