Re: [PATCH V2 16/18] be2iscsi: Fix possible reentrancy issue in be_iopoll

[James Bottomley <jbottomley@parallels.com>]

On Fri, 2013-04-05 at 20:38 -0700, Jayamohan Kallickal wrote:
> From: Shlomo Pongratz <shlomop@mellanox.com>
> 
>  The driver creates "NAPI" context per core which is fine,
>  however the above routine declares the ret variable as static!
>  Thus there is only one instance of this variable!
>  When this routine is called from more than one thread of execution,
>  than the result is unpredictable.
> 
>          static unsigned int ret;
>          .....
> 
>          ret = beiscsi_process_cq(pbe_eq);
>                  <--------Another thread can enter here and change "ret".
>          if (ret < budget) {
>                 ....
>          }
>                  <--------Another thread can enter here and change "ret".
>          return ret;
> 
>  Fix - remove the "static"
> 
> Signed-off-by: Shlomo Pongratz <shlomop@mellanox.com>
> Acked-by: Jayamohan Kallickal <jayamohan.kallickal@emulex.com>

The rule here is that this needs to be Signed-off-by: from you because
you sent the patch to me (signoffs follow the transmission path for the
patch).  If you just see the patch on the list and want me to apply it,
you give me an Acked-by, but if you actually pick the patch up and send
it to me it must have a signed-off-by.

I assumed your consent and changed the tag.

James