Re: [PATCH 2/6] scsi_debug: prohibit scsi_debug_unmap_granularity == scsi_debug_unmap_alignment

Martin K. Petersen
2013-04-25T01:36:48Z

>>>>> "Akinobu" == Akinobu Mita <akinobu.mita@gmail.com> writes:

Akinobu> scsi_debug prohibits setting scsi_debug_unmap_alignment to be
Akinobu> greater than scsi_debug_unmap_granularity. But setting them to
Akinobu> be the same value is not prohibited. In this case, the only
Akinobu> difference with scsi_debug_unmap_alignment == 0 is the logical
Akinobu> blocks from 0 to scsi_debug_unmap_alignment - 1 cannot be
Akinobu> unmapped. But the difference is not properly handled in the
Akinobu> current code.

Akinobu> So this prohibits such unusual setting.

Acked-by: Martin K. Petersen <martin.petersen@oracle.com>

--
Martin K. Petersen Oracle Linux Engineering