RE: 32-byte CDB support in Libsas?

Kamaljit Singh
2013-05-07T19:46:03Z

James, Jack,

Thanks for your responses.

> I don't understand the question ... it should just work; is it broken?
sas_create_task() only copies 16 bytes to the sas_ssp_task struct’s cdb field, which itself is a 16 byte wide array. So it looks like sas_queuecommand() doesn’t support a 32-byte cdb.

> It's easy to add that, define cdb 32 to ssp_task and modify sas_queuecommand, and lldd to pass it to fw
Yes, that’s exactly what I’ve designed it as, i.e. in my lldd’s queuecommand function. At the moment I only need this function for 32-byte cdb support. But if there are plans to add that to libsas then I’d prefer to use sas_queuecommand rather than having to do manual merges from future libsas fixes/updates.

> I wonder any user ask for cdb 32 support
No. Just testing right now.

Thanks,

Kamaljit

From: Jack Wang [mailto:xjtuwjp@gmail.com]
Sent: Monday, May 06, 2013 12:38 PM
To: James Bottomley
Cc: Kamaljit Singh; Anand Kumar Santhanam; linux-scsi@vger.kernel.org; Harry Yang; Vishwanath Maram; Sakthivel Saravanan Kamal Raju; Rich Bono; Sangeetha Gnanasekaran
Subject: Re: 32-byte CDB support in Libsas?

It's easy to add that, define cdb 32 to ssp_task and modify sas_queuecommand, and lldd to pass it to fw.

I wonder any user ask for cdb 32 support?

Regards
Jack

2013/5/6 James Bottomley <James.Bottomley@hansenpartnership.com>
On Mon, 2013-05-06 at 11:41 -0700, Kamaljit Singh wrote:
> Are there any plans to add 32-byte CDB support in Libsas?
I don't understand the question ... it should just work; is it broken?

James

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html