RE: [PATCH 1/6] Drivers: hv: vmbus: Implement multi-channel support

KY Srinivasan
2013-05-16T10:18:49Z

> -----Original Message-----
> From: Greg KH [mailto:gregkh@linuxfoundation.org]
> Sent: Thursday, May 16, 2013 12:02 AM
> To: KY Srinivasan
> Cc: linux-kernel@vger.kernel.org; devel@linuxdriverproject.org;
> ohering@suse.com; jbottomley@parallels.com; hch@infradead.org; linux-
> scsi@vger.kernel.org; apw@canonical.com; jasowang@redhat.com
> Subject: Re: [PATCH 1/6] Drivers: hv: vmbus: Implement multi-channel support
>
> On Wed, May 15, 2013 at 03:02:29PM -0700, K. Y. Srinivasan wrote:
> > +/*
> > + * Retrieve the (sub) channel on which to send an outgoing request.
> > + * When a primary channel has multiple sub-channels, we choose a
> > + * channel whose VCPU binding is closest to the VCPU on which
> > + * this call is being made.
> > + */
> > +struct vmbus_channel *get_outgoing_channel(struct vmbus_channel
> *primary)
>
> That's a _very_ vague global symbol name you are adding to the kernel.
> Same goes for the other functions you are adding here, please fix that,
> and make them have the vmbus_ prefix, like everything else in this
> patch.

Will do.

K. Y