From mboxrd@z Thu Jan 1 00:00:00 1970 From: Santosh Y Subject: [PATCH 4/8] scsi: ufs: remove version check before IS reg clear Date: Sun, 19 May 2013 13:51:39 +0530 Message-ID: <1368951703-2672-5-git-send-email-santoshsy@gmail.com> References: <1368951703-2672-1-git-send-email-santoshsy@gmail.com> Return-path: Received: from mail-pd0-f172.google.com ([209.85.192.172]:62405 "EHLO mail-pd0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753820Ab3ESIWR (ORCPT ); Sun, 19 May 2013 04:22:17 -0400 Received: by mail-pd0-f172.google.com with SMTP id 10so246952pdi.17 for ; Sun, 19 May 2013 01:22:16 -0700 (PDT) In-Reply-To: <1368951703-2672-1-git-send-email-santoshsy@gmail.com> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: james.bottomley@hansenpartnership.com Cc: linux-scsi@vger.kernel.org, vinholikatti@gmail.com, Seungwon Jeon , Santosh Y From: Seungwon Jeon There is no need to check the version to clear the interrupt status. And the order is changed prior to actual handling. Signed-off-by: Seungwon Jeon Tested-by: Maya Erez Signed-off-by: Santosh Y diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index aa2c8d2..b1ac21e 100644 --- a/drivers/scsi/ufs/ufshcd.c +++ b/drivers/scsi/ufs/ufshcd.c @@ -1478,11 +1478,8 @@ static irqreturn_t ufshcd_intr(int irq, void *__hba) intr_status = ufshcd_readl(hba, REG_INTERRUPT_STATUS); if (intr_status) { + ufshcd_writel(hba, intr_status, REG_INTERRUPT_STATUS); ufshcd_sl_intr(hba, intr_status); - - /* If UFSHCI 1.0 then clear interrupt status register */ - if (hba->ufs_version == UFSHCI_VERSION_10) - ufshcd_writel(hba, intr_status, REG_INTERRUPT_STATUS); retval = IRQ_HANDLED; } spin_unlock(hba->host->host_lock); -- 1.8.2.3