Re: [PATCH 2/2] scsi: qla2xxx: print MAC via %pMR

[Andy Shevchenko <andriy.shevchenko@linux.intel.com>]

On Thu, 2012-07-26 at 08:23 -0400, Chad Dupuis wrote: 
> 
> On Thu, 12 Jul 2012, Andy Shevchenko wrote:
> 
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > ---
> > drivers/scsi/qla2xxx/qla_attr.c |    5 +----
> > 1 file changed, 1 insertion(+), 4 deletions(-)
> >
> > diff --git a/drivers/scsi/qla2xxx/qla_attr.c b/drivers/scsi/qla2xxx/qla_attr.c
> > index 5ab9530..095ba85 100644
> > --- a/drivers/scsi/qla2xxx/qla_attr.c
> > +++ b/drivers/scsi/qla2xxx/qla_attr.c
> > @@ -1193,10 +1193,7 @@ qla2x00_vn_port_mac_address_show(struct device *dev,
> >       if (!IS_CNA_CAPABLE(vha->hw))
> >               return snprintf(buf, PAGE_SIZE, "\n");
> >
> > -     return snprintf(buf, PAGE_SIZE, "%02x:%02x:%02x:%02x:%02x:%02x\n",
> > -         vha->fcoe_vn_port_mac[5], vha->fcoe_vn_port_mac[4],
> > -         vha->fcoe_vn_port_mac[3], vha->fcoe_vn_port_mac[2],
> > -         vha->fcoe_vn_port_mac[1], vha->fcoe_vn_port_mac[0]);
> > +     return snprintf(buf, PAGE_SIZE, "%pMR\n", vha->fcoe_vn_port_mac);
> > }
> >
> > static ssize_t
> >
> 
> Acked-by: Chad Dupuis <chad.dupuis@qlogic.com>


James, do you have any comments on this patch and patch 1/2?

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy