From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Thomas Meyer <thomas@m3y3r.de>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [SCSI] libsas: Cocci spatch "ptr_ret.spatch"
Date: Sat, 01 Jun 2013 08:26:43 -0700 [thread overview]
Message-ID: <1370100403.2463.14.camel@dabdike> (raw)
In-Reply-To: <1370080781.29224.39.camel@localhost.localdomain>
On Sat, 2013-06-01 at 11:59 +0200, Thomas Meyer wrote:
> Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
> ---
>
> diff -u -p a/drivers/scsi/libsas/sas_scsi_host.c b/drivers/scsi/libsas/sas_scsi_host.c
> --- a/drivers/scsi/libsas/sas_scsi_host.c
> +++ b/drivers/scsi/libsas/sas_scsi_host.c
> @@ -1093,9 +1093,7 @@ int sas_init_queue(struct sas_ha_struct
>
> core->queue_thread = kthread_run(sas_queue_thread, sas_ha,
> "sas_queue_%d", core->shost->host_no);
> - if (IS_ERR(core->queue_thread))
> - return PTR_ERR(core->queue_thread);
> - return 0;
> + return PTR_RET(core->queue_thread);
> }
Really, no, this is not a good patch. I know exactly what the current
code is doing by reading it. With your patch I now have to go and look
up the definition of an obscure and non-standard macro.
If we're sacrificing clarity, I want a good reason and having two lines
fewer code isn't it.
James
prev parent reply other threads:[~2013-06-01 15:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-01 9:59 [PATCH] [SCSI] libsas: Cocci spatch "ptr_ret.spatch" Thomas Meyer
2013-06-01 15:26 ` James Bottomley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1370100403.2463.14.camel@dabdike \
--to=james.bottomley@hansenpartnership.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=thomas@m3y3r.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).