* [PATCH] [SCSI] libsas: Cocci spatch "ptr_ret.spatch"
@ 2013-06-01 9:59 Thomas Meyer
2013-06-01 15:26 ` James Bottomley
0 siblings, 1 reply; 2+ messages in thread
From: Thomas Meyer @ 2013-06-01 9:59 UTC (permalink / raw)
To: JBottomley, linux-scsi, linux-kernel
Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
---
diff -u -p a/drivers/scsi/libsas/sas_scsi_host.c b/drivers/scsi/libsas/sas_scsi_host.c
--- a/drivers/scsi/libsas/sas_scsi_host.c
+++ b/drivers/scsi/libsas/sas_scsi_host.c
@@ -1093,9 +1093,7 @@ int sas_init_queue(struct sas_ha_struct
core->queue_thread = kthread_run(sas_queue_thread, sas_ha,
"sas_queue_%d", core->shost->host_no);
- if (IS_ERR(core->queue_thread))
- return PTR_ERR(core->queue_thread);
- return 0;
+ return PTR_RET(core->queue_thread);
}
void sas_shutdown_queue(struct sas_ha_struct *sas_ha)
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] [SCSI] libsas: Cocci spatch "ptr_ret.spatch"
2013-06-01 9:59 [PATCH] [SCSI] libsas: Cocci spatch "ptr_ret.spatch" Thomas Meyer
@ 2013-06-01 15:26 ` James Bottomley
0 siblings, 0 replies; 2+ messages in thread
From: James Bottomley @ 2013-06-01 15:26 UTC (permalink / raw)
To: Thomas Meyer; +Cc: linux-scsi, linux-kernel
On Sat, 2013-06-01 at 11:59 +0200, Thomas Meyer wrote:
> Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
> ---
>
> diff -u -p a/drivers/scsi/libsas/sas_scsi_host.c b/drivers/scsi/libsas/sas_scsi_host.c
> --- a/drivers/scsi/libsas/sas_scsi_host.c
> +++ b/drivers/scsi/libsas/sas_scsi_host.c
> @@ -1093,9 +1093,7 @@ int sas_init_queue(struct sas_ha_struct
>
> core->queue_thread = kthread_run(sas_queue_thread, sas_ha,
> "sas_queue_%d", core->shost->host_no);
> - if (IS_ERR(core->queue_thread))
> - return PTR_ERR(core->queue_thread);
> - return 0;
> + return PTR_RET(core->queue_thread);
> }
Really, no, this is not a good patch. I know exactly what the current
code is doing by reading it. With your patch I now have to go and look
up the definition of an obscure and non-standard macro.
If we're sacrificing clarity, I want a good reason and having two lines
fewer code isn't it.
James
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-06-01 15:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-01 9:59 [PATCH] [SCSI] libsas: Cocci spatch "ptr_ret.spatch" Thomas Meyer
2013-06-01 15:26 ` James Bottomley
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).