From: Ewan Milne <emilne@redhat.com>
To: Hannes Reinecke <hare@suse.de>
Cc: James Bottomley <jbottomley@parallels.com>,
linux-scsi@vger.kernel.org, Joern Engel <joern@logfs.org>,
James Smart <james.smart@emulex.com>,
Ren Mingxin <renmx@cn.fujitsu.com>,
Roland Dreier <roland@purestorage.com>,
Bryn Reeves <bmr@redhat.com>,
Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH 7/7] scsi: Add 'eh_deadline' to limit SCSI EH runtime
Date: Fri, 28 Jun 2013 08:54:07 -0400 [thread overview]
Message-ID: <1372424047.3871.461.camel@localhost.localdomain> (raw)
In-Reply-To: <51CD37EE.4000803@suse.de>
On Fri, 2013-06-28 at 09:14 +0200, Hannes Reinecke wrote:
> >> @@ -232,6 +272,9 @@ int scsi_eh_scmd_add(struct scsi_cmnd *scmd, int eh_flag)
> >> if (scsi_host_set_state(shost, SHOST_CANCEL_RECOVERY))
> >> goto out_unlock;
> >>
> >> + if (sdev->eh_deadline && !shost->last_reset)
> >> + shost->last_reset = jiffies;
> >> +
> >
> > I think this is supposed to be if (shost->eh_deadline ...
> >
> No. ->last_reset is set to the time the first command timeout/failure.
>
> ->last_reset + ->eh_deadline will give you the expiry time.
Sorry, I wasn't clear what I meant. What I meant was:
if (shost->eh_deadline && !shost->last_reset)
shost->last_reset = jiffies;
...because the eh_deadline field is in struct Scsi_Host, not
in struct scsi_device.
-Ewan
next prev parent reply other threads:[~2013-06-28 12:54 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-10 11:11 [PATCH 0/7] Limit overall SCSI EH runtime Hannes Reinecke
2013-06-10 11:11 ` [PATCH 1/7] dpt_i2o: Remove DPTI_STATE_IOCTL Hannes Reinecke
2013-06-10 11:11 ` [PATCH 2/7] dpt_i2o: return SCSI_MLQUEUE_HOST_BUSY when in reset Hannes Reinecke
2013-06-10 11:11 ` [PATCH 3/7] advansys: Remove 'last_reset' references Hannes Reinecke
2013-06-10 11:11 ` [PATCH 4/7] tmscsim: Move 'last_reset' into host structure Hannes Reinecke
2013-06-10 11:11 ` [PATCH 5/7] dc395: Move 'last_reset' into internal " Hannes Reinecke
2013-06-10 11:11 ` [PATCH 6/7] scsi: remove check for 'resetting' Hannes Reinecke
2013-06-10 11:11 ` [PATCH 7/7] scsi: Add 'eh_deadline' to limit SCSI EH runtime Hannes Reinecke
2013-06-27 14:33 ` Ewan Milne
2013-06-28 7:14 ` Hannes Reinecke
2013-06-28 12:54 ` Ewan Milne [this message]
2013-06-28 7:29 ` Bart Van Assche
2013-06-28 7:42 ` Hannes Reinecke
2013-06-27 9:23 ` [PATCH 0/7] Limit overall " Ren Mingxin
-- strict thread matches above, loose matches on Subject: below --
2013-07-01 6:50 [PATCHv2 " Hannes Reinecke
2013-07-01 6:50 ` [PATCH 7/7] scsi: Add 'eh_deadline' to limit " Hannes Reinecke
2013-09-20 7:48 ` Ren Mingxin
2013-10-16 19:22 ` James Bottomley
2013-10-17 14:27 ` Ewan Milne
2013-10-23 9:25 ` Hannes Reinecke
2013-10-23 7:46 ` James Bottomley
2013-10-23 9:49 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1372424047.3871.461.camel@localhost.localdomain \
--to=emilne@redhat.com \
--cc=bmr@redhat.com \
--cc=hare@suse.de \
--cc=hch@infradead.org \
--cc=james.smart@emulex.com \
--cc=jbottomley@parallels.com \
--cc=joern@logfs.org \
--cc=linux-scsi@vger.kernel.org \
--cc=renmx@cn.fujitsu.com \
--cc=roland@purestorage.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox