From: Ewan Milne <emilne@redhat.com>
To: linux-scsi@vger.kernel.org
Cc: James Bottomley <jbottomley@parallels.com>
Subject: Re: [PATCH] [SCSI] sd: fix crash when UA received on DIF enabled device
Date: Wed, 10 Jul 2013 15:52:09 -0400 [thread overview]
Message-ID: <1373485929.7420.50.camel@localhost.localdomain> (raw)
In-Reply-To: <yq1liee4aaw.fsf@sermon.lab.mkp.net>
On Tue, 2012-11-06 at 17:48 -0500, Martin K. Petersen wrote:
> >>>>> "Ewan" == Ewan D Milne <emilne@redhat.com> writes:
>
> Ewan> sd_prep_fn will allocate a larger CDB for the command via
> Ewan> mempool_alloc for devices using DIF type 2 protection. This CDB
> Ewan> was being freed in sd_done, which results in a kernel crash if the
> Ewan> command is retried due to a UNIT ATTENTION. This change moves the
> Ewan> code to free the larger CDB into sd_unprep_fn instead, which is
> Ewan> invoked after the request is complete.
>
> The 32-byte CDB support predates unprep. This fix is obviously the
> correct approach.
>
> Acked-by: Martin K. Petersen <martin.petersen@oracle.com>
>
I don't see that this change ever made it in. Can this go in for
the 3.12 merge window?
http://marc.info/?l=linux-scsi&m=135186352200668&w=2
-Ewan
prev parent reply other threads:[~2013-07-10 19:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-02 13:38 [PATCH] [SCSI] sd: fix crash when UA received on DIF enabled device Ewan D. Milne
2012-11-06 22:48 ` Martin K. Petersen
2013-07-10 19:52 ` Ewan Milne [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1373485929.7420.50.camel@localhost.localdomain \
--to=emilne@redhat.com \
--cc=jbottomley@parallels.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox