From: Ewan Milne <emilne@redhat.com>
To: Hannes Reinecke <hare@suse.de>
Cc: James Bottomley <jbottomley@parallels.com>,
linux-scsi@vger.kernel.org, Ren Mingxin <renmx@cn.fujitsu.com>,
Bart van Assche <bvanassche@acm.org>,
Joern Engel <joern@logfs.org>
Subject: Re: [PATCHv2 0/7] Limit overall SCSI EH runtime
Date: Wed, 10 Jul 2013 16:35:28 -0400 [thread overview]
Message-ID: <1373488528.7420.55.camel@localhost.localdomain> (raw)
In-Reply-To: <1372661455-122384-1-git-send-email-hare@suse.de>
On Mon, 2013-07-01 at 08:50 +0200, Hannes Reinecke wrote:
> This patchset implements a new 'eh_deadline' attribute to the
> SCSI host. It will limit the overall SCSI EH runtime by a given
> timeout. If the timeout is reached all intermediate EH steps
> will be skipped and host reset will be scheduled immediately.
>
> For this patch I've re-used the existing 'last_reset' field
> of the SCSI host to store the initial time SCSI EH started.
> Also the field 'resetting' has been removed as it never has
> been used as intended.
>
> As 'last_reset' might be in use by transport-specific EH
> implementation I've disallowed eh_deadline setting there.
>
> Changes from the initial version:
> - Add list_splice_init() calls to avoid stale commands
> - Rename function to scsi_host_eh_past_deadline
>
> Hannes Reinecke (7):
> dpt_i2o: Remove DPTI_STATE_IOCTL
> dpt_i2o: return SCSI_MLQUEUE_HOST_BUSY when in reset
> advansys: Remove 'last_reset' references
> tmscsim: Move 'last_reset' into host structure
> dc395: Move 'last_reset' into internal host structure
> scsi: remove check for 'resetting'
> scsi: Add 'eh_deadline' to limit SCSI EH runtime
>
> drivers/scsi/advansys.c | 8 +--
> drivers/scsi/dc395x.c | 24 +++++----
> drivers/scsi/dpt_i2o.c | 35 +++++--------
> drivers/scsi/dpti.h | 1 -
> drivers/scsi/hosts.c | 7 +++
> drivers/scsi/scsi.c | 28 ----------
> drivers/scsi/scsi_error.c | 130 +++++++++++++++++++++++++++++++++++++++++++---
> drivers/scsi/scsi_sysfs.c | 37 +++++++++++++
> drivers/scsi/tmscsim.c | 14 ++---
> drivers/scsi/tmscsim.h | 1 +
> include/scsi/scsi_host.h | 4 +-
> 11 files changed, 208 insertions(+), 81 deletions(-)
>
Looks good. We have been testing this extensively.
Acked-by: Ewan D. Milne <emilne@redhat.com>
next prev parent reply other threads:[~2013-07-10 20:35 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-01 6:50 [PATCHv2 0/7] Limit overall SCSI EH runtime Hannes Reinecke
2013-07-01 6:50 ` [PATCH 1/7] dpt_i2o: Remove DPTI_STATE_IOCTL Hannes Reinecke
2013-07-01 6:50 ` [PATCH 2/7] dpt_i2o: return SCSI_MLQUEUE_HOST_BUSY when in reset Hannes Reinecke
2013-07-01 6:50 ` [PATCH 3/7] advansys: Remove 'last_reset' references Hannes Reinecke
2013-07-01 6:50 ` [PATCH 4/7] tmscsim: Move 'last_reset' into host structure Hannes Reinecke
2013-07-01 6:50 ` [PATCH 5/7] dc395: Move 'last_reset' into internal " Hannes Reinecke
2013-07-01 6:50 ` [PATCH 6/7] scsi: remove check for 'resetting' Hannes Reinecke
2013-07-01 6:50 ` [PATCH 7/7] scsi: Add 'eh_deadline' to limit SCSI EH runtime Hannes Reinecke
2013-09-20 7:48 ` Ren Mingxin
2013-10-16 19:22 ` James Bottomley
2013-10-17 14:27 ` Ewan Milne
2013-10-23 9:25 ` Hannes Reinecke
2013-10-23 7:46 ` James Bottomley
2013-10-23 9:49 ` Hannes Reinecke
2013-07-01 17:44 ` [PATCHv2 0/7] Limit overall " Jörn Engel
2013-07-01 19:23 ` James Bottomley
2013-07-01 20:55 ` Jörn Engel
2013-07-02 5:48 ` Hannes Reinecke
2013-07-02 6:37 ` James Bottomley
2013-07-02 14:58 ` Jörn Engel
2013-07-02 16:33 ` James Bottomley
2013-07-02 15:50 ` Jörn Engel
2013-07-10 20:35 ` Ewan Milne [this message]
2013-07-12 5:54 ` Ren Mingxin
2013-07-12 13:30 ` Ewan Milne
2013-07-15 10:33 ` Ren Mingxin
2013-07-26 9:52 ` Ren Mingxin
2013-08-07 6:43 ` Ren Mingxin
2013-08-29 13:06 ` Hannes Reinecke
2013-09-24 20:51 ` Ric Wheeler
2013-09-25 5:48 ` Hannes Reinecke
2013-10-02 16:21 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1373488528.7420.55.camel@localhost.localdomain \
--to=emilne@redhat.com \
--cc=bvanassche@acm.org \
--cc=hare@suse.de \
--cc=jbottomley@parallels.com \
--cc=joern@logfs.org \
--cc=linux-scsi@vger.kernel.org \
--cc=renmx@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).