From: Santosh Y <santoshsy@gmail.com>
To: james.bottomley@hansenpartnership.com
Cc: linux-scsi@vger.kernel.org, vinholikatti@gmail.com,
Akinobu Mita <mita@fixstars.com>,
"James E.J. Bottomley" <JBottomley@parallels.com>,
Santosh Y <santoshsy@gmail.com>
Subject: [PATCH 6/9] ufs: don't disable_irq() if the IRQ can be shared among devices
Date: Sun, 28 Jul 2013 22:40:34 +0530 [thread overview]
Message-ID: <1375031437-10206-7-git-send-email-santoshsy@gmail.com> (raw)
In-Reply-To: <1375031437-10206-1-git-send-email-santoshsy@gmail.com>
From: Akinobu Mita <mita@fixstars.com>
When removing the UFS driver, disable_irq() is called and the IRQ is
not enabled again. Unfortunately, the IRQ is requested with IRQF_SHARED
and it can be shared among several devices. So disabling the IRQ in
this way is just breaking other devices which are sharing the IRQ.
Signed-off-by: Akinobu Mita <mita@fixstars.com>
Cc: Vinayak Holikatti <vinholikatti@gmail.com>
Cc: "James E.J. Bottomley" <JBottomley@parallels.com>
Cc: linux-scsi@vger.kernel.org
Signed-off-by: Santosh Y <santoshsy@gmail.com>
diff --git a/drivers/scsi/ufs/ufshcd-pci.c b/drivers/scsi/ufs/ufshcd-pci.c
index 24d6ba7..a823cf4 100644
--- a/drivers/scsi/ufs/ufshcd-pci.c
+++ b/drivers/scsi/ufs/ufshcd-pci.c
@@ -131,8 +131,6 @@ static void ufshcd_pci_remove(struct pci_dev *pdev)
pm_runtime_forbid(&pdev->dev);
pm_runtime_get_noresume(&pdev->dev);
-
- disable_irq(pdev->irq);
ufshcd_remove(hba);
pci_set_drvdata(pdev, NULL);
}
diff --git a/drivers/scsi/ufs/ufshcd-pltfrm.c b/drivers/scsi/ufs/ufshcd-pltfrm.c
index cc957fc..13b8c5a 100644
--- a/drivers/scsi/ufs/ufshcd-pltfrm.c
+++ b/drivers/scsi/ufs/ufshcd-pltfrm.c
@@ -186,8 +186,6 @@ static int ufshcd_pltfrm_remove(struct platform_device *pdev)
struct ufs_hba *hba = platform_get_drvdata(pdev);
pm_runtime_get_sync(&(pdev)->dev);
-
- disable_irq(hba->irq);
ufshcd_remove(hba);
return 0;
}
--
1.8.3.1
next prev parent reply other threads:[~2013-07-28 17:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-28 17:10 [PATCH 0/9] scsi:ufs: query, bkops support and other fixes Santosh Y
2013-07-28 17:10 ` [PATCH 1/9] scsi: ufs: Add support for sending NOP OUT UPIU Santosh Y
2013-07-28 17:10 ` [PATCH 2/9] scsi: ufs: Set fDeviceInit flag to initiate device initialization Santosh Y
2013-07-28 17:10 ` [PATCH 3/9] scsi: ufs: Add support for host assisted background operations Santosh Y
2013-07-28 17:10 ` [PATCH 4/9] scsi: ufs: Add runtime PM support for UFS host controller driver Santosh Y
2013-07-29 18:13 ` Sujit Reddy Thumma
2013-07-29 18:24 ` Santosh Y
2013-07-28 17:10 ` [PATCH 5/9] ufshcd-pci: release ioremapped region during removing driver Santosh Y
2013-07-28 17:10 ` Santosh Y [this message]
2013-07-28 17:10 ` [PATCH 7/9] ufs: don't stop controller before scsi_remove_host() Santosh Y
2013-07-28 17:10 ` [PATCH 8/9] ufshcd-pltfrm: remove redundant dev_err call in ufshcd_pltfrm_probe() Santosh Y
2013-07-28 17:10 ` [PATCH 9/9] drivers/scsi/ufs: don't check resource with devm_ioremap_resource Santosh Y
2013-07-29 19:05 ` [PATCH 0/9] scsi:ufs: query, bkops support and other fixes Santosh Y
-- strict thread matches above, loose matches on Subject: below --
2013-07-29 19:05 Santosh Y
2013-07-29 19:06 ` [PATCH 6/9] ufs: don't disable_irq() if the IRQ can be shared among devices Santosh Y
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1375031437-10206-7-git-send-email-santoshsy@gmail.com \
--to=santoshsy@gmail.com \
--cc=JBottomley@parallels.com \
--cc=james.bottomley@hansenpartnership.com \
--cc=linux-scsi@vger.kernel.org \
--cc=mita@fixstars.com \
--cc=vinholikatti@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).