From: Oliver Neukum <oneukum-l3A5Bk7waGM@public.gmane.org>
To: Alan Stern <stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org>
Cc: Andy Lutomirski <luto-kltTT9wpgjJwATOyAt5JVQ@public.gmane.org>,
linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Linux PM List
<linux-pm-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>,
Linux SCSI List
<linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
hare-l3A5Bk7waGM@public.gmane.org
Subject: Re: Ejected Nook (usb mass storage) prevents suspend
Date: Tue, 30 Jul 2013 17:12:22 +0200 [thread overview]
Message-ID: <1375197142.14458.4.camel@linux-fkkt.site> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1307291016220.1479-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
On Mon, 2013-07-29 at 10:21 -0400, Alan Stern wrote:
> On Mon, 29 Jul 2013, Oliver Neukum wrote:
>
> > On Fri, 2013-07-26 at 16:31 -0400, Alan Stern wrote:
> >
> > > In addition to my earlier comment, the patch below should be applied.
> > > It will fix your immediate problem, although not in the best way.
> >
> > Alan,
> >
> > I think your diagnosis is correct, but not the fix.
> > This is run even in the runtime case. We might lose
> > data if the flush is not done.
>
> Actually no, the scsi_bus_suspend_common() routine does not run during
> runtime PM. It gets called only from scsi_bus_suspend(),
> scsi_bus_freeze(), and scsi_bus_poweroff(), which are all part of
> system sleep.
Well yes, but you handled only the system case that way. The runtime
case is still affected.
Regards
Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-07-30 15:12 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-26 16:54 Ejected Nook (usb mass storage) prevents suspend Andy Lutomirski
2013-07-26 17:40 ` Alan Stern
[not found] ` <CALCETrVoMc+aCNgwthdwYzx9rXh=Zqzwb5e2djwbFB8FTo4kRg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-07-26 20:31 ` Alan Stern
2013-07-29 6:06 ` Oliver Neukum
2013-07-29 14:21 ` Alan Stern
[not found] ` <Pine.LNX.4.44L0.1307291016220.1479-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2013-07-30 15:12 ` Oliver Neukum [this message]
[not found] ` <1375197142.14458.4.camel-B2T3B9s34ElbnMAlSieJcQ@public.gmane.org>
2013-07-30 17:00 ` Alan Stern
2013-07-30 19:26 ` Oliver Neukum
2013-07-31 11:39 ` Oliver Neukum
2013-07-31 15:13 ` Alan Stern
2013-08-01 14:12 ` Oliver Neukum
2013-08-01 15:53 ` Alan Stern
[not found] ` <Pine.LNX.4.44L0.1308011149320.1534-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2013-08-02 7:23 ` Oliver Neukum
2013-08-02 13:54 ` Alan Stern
[not found] ` <Pine.LNX.4.44L0.1308020954120.1176-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2013-08-02 14:11 ` Oliver Neukum
[not found] ` <1375452665.2138.17.camel-B2T3B9s34ElbnMAlSieJcQ@public.gmane.org>
2013-08-02 14:18 ` Alan Stern
[not found] ` <Pine.LNX.4.44L0.1308021015200.1176-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2013-09-13 13:37 ` Andy Lutomirski
[not found] ` <CALCETrWQuJs_7-VoOVaZQMCdZhj2VjQCaH5NWie=h4NSAM9VSg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-09-13 15:19 ` Oliver Neukum
2013-07-29 6:02 ` Oliver Neukum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1375197142.14458.4.camel@linux-fkkt.site \
--to=oneukum-l3a5bk7wagm@public.gmane.org \
--cc=hare-l3A5Bk7waGM@public.gmane.org \
--cc=linux-pm-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=luto-kltTT9wpgjJwATOyAt5JVQ@public.gmane.org \
--cc=stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).