From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oliver Neukum Subject: Re: Ejected Nook (usb mass storage) prevents suspend Date: Tue, 30 Jul 2013 17:12:22 +0200 Message-ID: <1375197142.14458.4.camel@linux-fkkt.site> References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Alan Stern Cc: Andy Lutomirski , linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Linux PM List , Linux SCSI List , hare-l3A5Bk7waGM@public.gmane.org List-Id: linux-scsi@vger.kernel.org On Mon, 2013-07-29 at 10:21 -0400, Alan Stern wrote: > On Mon, 29 Jul 2013, Oliver Neukum wrote: > > > On Fri, 2013-07-26 at 16:31 -0400, Alan Stern wrote: > > > > > In addition to my earlier comment, the patch below should be applied. > > > It will fix your immediate problem, although not in the best way. > > > > Alan, > > > > I think your diagnosis is correct, but not the fix. > > This is run even in the runtime case. We might lose > > data if the flush is not done. > > Actually no, the scsi_bus_suspend_common() routine does not run during > runtime PM. It gets called only from scsi_bus_suspend(), > scsi_bus_freeze(), and scsi_bus_poweroff(), which are all part of > system sleep. Well yes, but you handled only the system case that way. The runtime case is still affected. Regards Oliver -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html