From: Oliver Neukum <oneukum@suse.de>
To: "Brandt, Todd E" <todd.e.brandt@intel.com>
Cc: "linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] Hard disk S3 resume time optimization
Date: Fri, 02 Aug 2013 14:42:36 +0200 [thread overview]
Message-ID: <1375447356.2138.13.camel@linux-fkkt.site> (raw)
In-Reply-To: <11E08D716F0541429B7042699DD5C1A1706803A6@FMSMSX103.amr.corp.intel.com>
On Thu, 2013-08-01 at 23:40 +0000, Brandt, Todd E wrote:
> This patch is a potential way to reduce the S3 resume time for SATA drives. Essentially this patch removes the hard disk resume time from the total system resume time, with the disks still taking as long to come back online but in the background.
>
> The major bottleneck is in the ata port resume which sends out a wakeup command and then waits up to several seconds for the port to resume. This patch changes the ata_port_resume_common function to be non blocking. The other bottleneck is in the scsi disk resume code, which issues a a command to startup the disk with blk_execute_rq, which then waits for the command to finish (which also depends on the ata port being fully resumed). The patch switches the sd_resume function to use blk_execute_rq_nowait instead (the underlying code is identical to sd_resume, but is changed to non-blocking).
But how do we know the command has succeeded?
Regards
Oliver
next prev parent reply other threads:[~2013-08-02 12:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-01 23:40 [PATCH] Hard disk S3 resume time optimization Brandt, Todd E
2013-08-02 12:42 ` Oliver Neukum [this message]
2013-08-02 16:41 ` Brandt, Todd E
2013-08-02 17:05 ` Oliver Neukum
2013-08-02 17:12 ` Brandt, Todd E
-- strict thread matches above, loose matches on Subject: below --
2013-05-16 22:29 Brandt, Todd E
2013-05-16 22:44 ` Tejun Heo
2013-05-16 22:47 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1375447356.2138.13.camel@linux-fkkt.site \
--to=oneukum@suse.de \
--cc=linux-ide@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=todd.e.brandt@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox