From: Oliver Neukum <oliver@neukum.org>
To: Jingoo Han <jg1.han@samsung.com>
Cc: 'James Bottomley' <JBottomley@Parallels.com>,
'Ali Akcaagac' <aliakc@web.de>,
'Jamie Lenehan' <lenehan@twibble.org>,
dc395x@twibble.org, 'James Bottomley' <jejb@kernel.org>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH 3/8] [SCSI] dc395x: use NULL instead of 0
Date: Wed, 07 Aug 2013 12:14:58 +0200 [thread overview]
Message-ID: <1375870498.1747.3.camel@linux-fkkt.site> (raw)
In-Reply-To: <002f01ce933b$96ebc370$c4c34a50$@samsung.com>
On Wed, 2013-08-07 at 15:58 +0900, Jingoo Han wrote:
> On Wednesday, August 07, 2013 3:50 PM, Oliver Neukum wrote:
> > On Wed, 2013-08-07 at 12:55 +0900, Jingoo Han wrote:
> >
> > > @@ -4183,15 +4183,17 @@ static void check_eeprom(struct NvRamType *eeprom, unsigned long io_port)
> > > */
> > > dprintkl(KERN_WARNING,
> > > "EEProm checksum error: using default values and options.\n");
> > > - eeprom->sub_vendor_id[0] = (u8)PCI_VENDOR_ID_TEKRAM;
> > > + eeprom->sub_vendor_id[0] = (u8)(PCI_VENDOR_ID_TEKRAM & 0xff);
> >
> > Hi,
> >
> > if you are fixing these issues please use the proper macros for
> > conversion of endianness.
>
> Sorry, I cannot understand exactly what you mean. :(
> Would you please let me know which macros can be used?
In this case constant_cpu_to_le16() would be the macro you want.
Have a look at include/uapi/linux/byteorder/
Regards
Oliver
next prev parent reply other threads:[~2013-08-07 10:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-07 3:55 [PATCH 3/8] [SCSI] dc395x: use NULL instead of 0 Jingoo Han
2013-08-07 6:50 ` Oliver Neukum
2013-08-07 6:58 ` Jingoo Han
2013-08-07 10:14 ` Oliver Neukum [this message]
2013-08-07 7:45 ` Jingoo Han
2013-08-07 8:20 ` Julian Calaby
2013-08-07 8:36 ` Jingoo Han
2013-08-07 8:39 ` Julian Calaby
2013-08-07 8:51 ` Jingoo Han
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1375870498.1747.3.camel@linux-fkkt.site \
--to=oliver@neukum.org \
--cc=JBottomley@Parallels.com \
--cc=aliakc@web.de \
--cc=dc395x@twibble.org \
--cc=jejb@kernel.org \
--cc=jg1.han@samsung.com \
--cc=lenehan@twibble.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox