Re: [PATCH 3/8] [SCSI] dc395x: use NULL instead of 0

Oliver Neukum
2013-08-07T10:15:02Z

On Wed, 2013-08-07 at 15:58 +0900, Jingoo Han wrote:
> On Wednesday, August 07, 2013 3:50 PM, Oliver Neukum wrote:
> > On Wed, 2013-08-07 at 12:55 +0900, Jingoo Han wrote:
> >
> > > @@ -4183,15 +4183,17 @@ static void check_eeprom(struct NvRamType *eeprom, unsigned long io_port)
> > > */
> > > dprintkl(KERN_WARNING,
> > > "EEProm checksum error: using default values and options.\n");
> > > - eeprom->sub_vendor_id[0] = (u8)PCI_VENDOR_ID_TEKRAM;
> > > + eeprom->sub_vendor_id[0] = (u8)(PCI_VENDOR_ID_TEKRAM & 0xff);
> >
> > Hi,
> >
> > if you are fixing these issues please use the proper macros for
> > conversion of endianness.
>
> Sorry, I cannot understand exactly what you mean. :(
> Would you please let me know which macros can be used?

In this case constant_cpu_to_le16() would be the macro you want.
Have a look at include/uapi/linux/byteorder/

Regards
Oliver