From: Oliver Neukum <oneukum@suse.de>
To: "Brandt, Todd E" <todd.e.brandt@intel.com>
Cc: linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org,
tj@kernel.org, gregkh@linuxfoundation.org,
stern@rowland.harvard.edu
Subject: Re: [PATCH v3 2/2] Hard disk S3 resume time optimization
Date: Sat, 24 Aug 2013 10:21:25 +0200 [thread overview]
Message-ID: <1377332485.1790.3.camel@linux-fkkt.site> (raw)
In-Reply-To: <20130823214340.GC11321@todd.e.brandt@intel.com>
On Fri, 2013-08-23 at 14:43 -0700, Brandt, Todd E wrote:
> This is v3 of the non-blocking S3 resume patch. It's been broken into
> two pieces, this part is for the scsi subsystem. I've addressed Alan
> Stern's comments in particular by reformatting the call to conform
> to the proper style guidelines.
Hi,
you are changing the generic resume for all sd disks.
In particular, you are dropping the check of
sdkp->device->manage_start_stop
What happens if you use this patch on a real SCSI disk?
Regards
Oliver
next parent reply other threads:[~2013-08-24 9:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20130823214340.GC11321@todd.e.brandt@intel.com>
2013-08-24 8:21 ` Oliver Neukum [this message]
2013-08-27 14:50 ` [PATCH v3 2/2] Hard disk S3 resume time optimization Brandt, Todd E
[not found] <20130823223535.GB11706@todd.e.brandt@intel.com>
2013-08-27 14:41 ` Brandt, Todd E
2014-01-08 0:56 [PATCH/RESEND v2 1/2] " Todd E Brandt
2014-01-11 19:13 ` Tejun Heo
2014-01-13 19:55 ` Todd E Brandt
2014-01-13 20:30 ` Tejun Heo
2014-01-15 0:32 ` [PATCH v3 2/2] " Todd E Brandt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1377332485.1790.3.camel@linux-fkkt.site \
--to=oneukum@suse.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=tj@kernel.org \
--cc=todd.e.brandt@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).