public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Sreekanth Reddy <Sreekanth.Reddy@lsi.com>
Cc: linux-scsi <linux-scsi@vger.kernel.org>,
	Sathya.Prakash@lsi.com, Nagalakshmi.Nandigama@lsi.com
Subject: Re: [PATCH 5/8][SCSI] mpt2sas: Infinite loop can occur if MPI2_IOCSTATUS_CONFIG_INVALID_PAGE is not returned
Date: Mon, 26 Aug 2013 12:41:26 +0400	[thread overview]
Message-ID: <1377506486.3469.3.camel@dabdike> (raw)
In-Reply-To: <1374760824.1952.1.camel@dabdike>

On Thu, 2013-07-25 at 07:00 -0700, James Bottomley wrote:
> On Thu, 2013-07-25 at 11:29 +0530, Sreekanth Reddy wrote:
> > Infinite loop can occur if IOCStatus is not equal to
> > MPI2_IOCSTATUS_CONFIG_INVALID_PAGE value in the while loops in functions
> > _scsih_search_responding_sas_devices,
> > _scsih_search_responding_raid_devices and
> > _scsih_search_responding_expanders
> > 
> > So, Instead of checking for MPI2_IOCSTATUS_CONFIG_INVALID_PAGE value,
> > in this patch code is modified to check for IOCStatus not equals to
> > MPI2_IOCSTATUS_SUCCESS to break the while loop.
> > 
> > Signed-off-by: Sreekanth Reddy <Sreekanth.Reddy@lsi.com>
> > Cc: stable@vger.kernel.org
> 
> Patches like this aren't acceptable any more: Greg will find this and
> reject it from Stable.
> 
> If there's a bug in the driver, it needs to be in a separate patch set
> for the fixes branch of SCSI to go upstream now rather than waiting for
> the merge window.  Only patches for the fixes branch can be tagged for
> stable.

Ping on this, please.  What do you want me to do?  I can strip the cc:
stable from the series and send it to the misc branch or you can
resubmit as two series: one for fixes with the stable tags and the rest
for misc.

James



  reply	other threads:[~2013-08-26  8:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-25  5:59 [PATCH 5/8][SCSI] mpt2sas: Infinite loop can occur if MPI2_IOCSTATUS_CONFIG_INVALID_PAGE is not returned Sreekanth Reddy
2013-07-25 14:00 ` James Bottomley
2013-08-26  8:41   ` James Bottomley [this message]
2013-08-26  8:59     ` Reddy, Sreekanth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1377506486.3469.3.camel@dabdike \
    --to=james.bottomley@hansenpartnership.com \
    --cc=Nagalakshmi.Nandigama@lsi.com \
    --cc=Sathya.Prakash@lsi.com \
    --cc=Sreekanth.Reddy@lsi.com \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox