[TRIVIAL PATCH 0/2] Fix warnings in kernel build

[TRIVIAL PATCH 0/2] Fix warnings in kernel build

[Ewan D. Milne]

From: "Ewan D. Milne" <emilne@redhat.com>

The patch to add uevents for certain Unit Attention codes
had a couple of problems which were found by a kbuild test robot.
Sorry about that, I will be more careful next time.

Ewan D. Milne (2):
  scsi: Add missing @sdev parameter description to scsi_report_sense()
  scsi: Remove unused variable "flags" from scsi_report_sense()

 drivers/scsi/scsi_error.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
1.7.11.7

[TRIVIAL PATCH 1/2] scsi: Add missing @sdev parameter description to scsi_report_sense()

[Ewan D. Milne]

From: "Ewan D. Milne" <emilne@redhat.com>

Signed-off-by: Ewan D. Milne <emilne@redhat.com>
---
 drivers/scsi/scsi_error.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c
index 598afd9..cf6fd20 100644
--- a/drivers/scsi/scsi_error.c
+++ b/drivers/scsi/scsi_error.c
@@ -241,6 +241,7 @@ static void scsi_report_lun_change(struct scsi_device *sdev)
 /**
  * scsi_report_sense - Examine scsi sense information and log messages for
  *		       certain conditions, also issue uevents for some of them.
+ * @sdev:	Device reporting sense information
  * @sshdr:	sshdr to be examined
  */
 static void scsi_report_sense(struct scsi_device *sdev,
-- 
1.7.11.7

[TRIVIAL PATCH 2/2] scsi: Remove unused variable "flags" from scsi_report_sense()

[Ewan D. Milne]

From: "Ewan D. Milne" <emilne@redhat.com>

Signed-off-by: Ewan D. Milne <emilne@redhat.com>
---
 drivers/scsi/scsi_error.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c
index cf6fd20..7f95236 100644
--- a/drivers/scsi/scsi_error.c
+++ b/drivers/scsi/scsi_error.c
@@ -248,7 +248,6 @@ static void scsi_report_sense(struct scsi_device *sdev,
 			      struct scsi_sense_hdr *sshdr)
 {
 	enum scsi_device_event evt_type = SDEV_EVT_MAXBITS;	/* i.e. none */
-	unsigned long flags;
 
 	if (sshdr->sense_key == UNIT_ATTENTION) {
 		if (sshdr->asc == 0x3f && sshdr->ascq == 0x03) {
-- 
1.7.11.7

Re: [TRIVIAL PATCH 0/2] Fix warnings in kernel build

[James Bottomley]

On Mon, 2013-08-26 at 13:06 -0400, Ewan D. Milne wrote:
> From: "Ewan D. Milne" <emilne@redhat.com>
> 
> The patch to add uevents for certain Unit Attention codes
> had a couple of problems which were found by a kbuild test robot.
> Sorry about that, I will be more careful next time.

I already did both of these based on Fengguang's checker results ...

James