From: James Bottomley <jbottomley@parallels.com>
To: Saurav Kashyap <saurav.kashyap@qlogic.com>
Cc: "giridhar.malavali@qlogic.com" <giridhar.malavali@qlogic.com>,
"andrew.vasquez@qlogic.com" <andrew.vasquez@qlogic.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH 02/29] qla2xxx: Add support for ISP8044.
Date: Wed, 28 Aug 2013 07:15:09 +0000 [thread overview]
Message-ID: <1377674108.2005.32.camel@dabdike> (raw)
In-Reply-To: <1377581875-8574-3-git-send-email-saurav.kashyap@qlogic.com>
On Tue, 2013-08-27 at 01:37 -0400, Saurav Kashyap wrote:
> From: Atul Deshmukh <atul.deshmukh@qlogic.com>
You seem to have stopped running your stuff through checkpatch:
WARNING: please, no spaces at the start of a line
#317: FILE: drivers/scsi/qla2xxx/qla_gbl.h:479:
+ uint8_t *, uint32_t, uint32_t);$
WARNING: please, no spaces at the start of a line
#341: FILE: drivers/scsi/qla2xxx/qla_gbl.h:713:
+ const uint32_t crb_reg, const uint32_t value);$
WARNING: please, no spaces at the start of a line
#351: FILE: drivers/scsi/qla2xxx/qla_gbl.h:723:
+ uint32_t, uint32_t);$
WARNING: please, no spaces at the start of a line
#3175: FILE: drivers/scsi/qla2xxx/qla_nx2.c:2084:
+ struct qla8044_minidump_entry_hdr *entry_hdr)$
WARNING: please, no spaces at the start of a line
#4258: FILE: drivers/scsi/qla2xxx/qla_nx2.c:3167:
+ uint32_t data)$
WARNING: please, no spaces at the start of a line
#4334: FILE: drivers/scsi/qla2xxx/qla_nx2.c:3243:
+ uint32_t sector_start_addr)$
WARNING: please, no spaces at the start of a line
#4390: FILE: drivers/scsi/qla2xxx/qla_nx2.c:3299:
+ uint32_t *p_data)$
WARNING: please, no spaces at the start of a line
#4425: FILE: drivers/scsi/qla2xxx/qla_nx2.c:3334:
+ uint32_t faddr, uint32_t dwords)$
WARNING: please, no spaces at the start of a line
#4508: FILE: drivers/scsi/qla2xxx/qla_nx2.c:3417:
+ uint32_t faddr, uint32_t dwords)$
WARNING: please, no spaces at the start of a line
#4528: FILE: drivers/scsi/qla2xxx/qla_nx2.c:3437:
+ uint32_t offset, uint32_t length)$
total: 0 errors, 10 warnings, 5781 lines checked
Please don't; those are all legitimate problems.
James
next prev parent reply other threads:[~2013-08-28 7:15 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-27 5:37 [PATCH 00/29] Update driver to 8.06.00.08-k Saurav Kashyap
2013-08-27 5:37 ` [PATCH 01/29] qla2xxx: Print some variables to hexadecimal string via %*phN format Saurav Kashyap
2013-08-27 5:37 ` [PATCH 02/29] qla2xxx: Add support for ISP8044 Saurav Kashyap
2013-08-28 7:15 ` James Bottomley [this message]
2013-08-28 13:33 ` Saurav Kashyap
2013-08-27 5:37 ` [PATCH 03/29] qla2xxx: Fix incorrect test after list_for_each_entry() exits Saurav Kashyap
2013-08-27 5:37 ` [PATCH 04/29] qla2xxx: Correct multiqueue offset calculations Saurav Kashyap
2013-08-27 5:37 ` [PATCH 05/29] qla2xxx: Set factory reset recovery timeout to 10 min. for ISPFX00 Saurav Kashyap
2013-08-27 5:37 ` [PATCH 06/29] qla2xxx: Perform warm reset every 2 minutes if firmware load fails " Saurav Kashyap
2013-08-27 5:37 ` [PATCH 07/29] qla2xxx: Add ISPFX00 specific bus reset routine Saurav Kashyap
2013-08-27 5:37 ` [PATCH 08/29] qla2xxx: Remove QL_DEBUG_LEVEL_17 defines from qla_nx.c Saurav Kashyap
2013-08-27 5:37 ` [PATCH 09/29] qla2xxx: Add setting of driver version string for vendor application Saurav Kashyap
2013-08-27 5:37 ` [PATCH 10/29] qla2xxx: Reconfigure thermal temperature Saurav Kashyap
2013-08-27 5:37 ` [PATCH 11/29] qla2xxx: Notify ISPFX00 firmware when driver is unloaded or system is shut down Saurav Kashyap
2013-08-27 5:37 ` [PATCH 12/29] qla2xxx: Add critical temperature handling for ISPFX00 Saurav Kashyap
2013-08-27 5:37 ` [PATCH 13/29] qla2xxx: Make log message that prints when a completion status requires a port down more readable Saurav Kashyap
2013-08-27 5:37 ` [PATCH 14/29] qla2xxx: Add missing FCP statistics to sysfs interface Saurav Kashyap
2013-08-27 5:37 ` [PATCH 15/29] qla2xxx: Add changes to support extended IOs for ISPFX00 Saurav Kashyap
2013-08-27 5:37 ` [PATCH 16/29] qla2xxx: Add changes in initialization for ISPFX00 cards with BIOS Saurav Kashyap
2013-08-27 5:37 ` [PATCH 17/29] qla2xxx: Send all AENs for ISPFx00 to above layers Saurav Kashyap
2013-08-27 5:37 ` [PATCH 18/29] qla2xxx: Remove handling of Shutdown Requested AEN from qlafx00_process_aen() Saurav Kashyap
2013-08-27 5:37 ` [PATCH 19/29] qla2xxx: Correct Interrupt Register offset for ISPFX00 Saurav Kashyap
2013-08-27 5:37 ` [PATCH 20/29] qla2xxx: QLAFX00 make over temperature AEN handling informational, add log for normal temperature AEN Saurav Kashyap
2013-08-27 5:37 ` [PATCH 21/29] qla2xxx: Set default critical temperature value in cases when ISPFX00 firmware doesn't provide it Saurav Kashyap
2013-08-27 5:37 ` [PATCH 22/29] qla2xxx: Add loopback IDC-TIME-EXTEND aen handling support Saurav Kashyap
2013-08-27 5:37 ` [PATCH 23/29] qla2xxx: Select link initialization option bits from current operating mode Saurav Kashyap
2013-08-27 5:37 ` [PATCH 24/29] qla2xxx: Move queue depth ramp down message to i/o debug level Saurav Kashyap
2013-08-27 5:37 ` [PATCH 25/29] qla2xxx: Add a new interface to update versions Saurav Kashyap
2013-08-27 5:37 ` [PATCH 26/29] qla2xxx: Correctly print out/in mailbox registers Saurav Kashyap
2013-08-27 5:37 ` [PATCH 27/29] qla2xxx: Correction to message ids Saurav Kashyap
2013-08-27 5:37 ` [PATCH 28/29] qla2xxx: print MAC via %pMR Saurav Kashyap
2013-08-27 5:37 ` [PATCH 29/29] qla2xxx: Update the driver version to 8.06.00.08-k Saurav Kashyap
2013-08-28 3:24 ` [PATCH 00/29] Update driver " James Bottomley
2013-08-28 4:31 ` Saurav Kashyap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1377674108.2005.32.camel@dabdike \
--to=jbottomley@parallels.com \
--cc=andrew.vasquez@qlogic.com \
--cc=giridhar.malavali@qlogic.com \
--cc=linux-scsi@vger.kernel.org \
--cc=saurav.kashyap@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).