From: Hiral Patel <hiralpat@cisco.com>
To: linux-scsi@vger.kernel.org
Cc: JBottomley@parallels.com, Brian Uchino <buchino@cisco.com>,
Hiral Patel <hiralpat@cisco.com>
Subject: [PATCH 3/9] fnic: On system with >1.1TB RAM, VIC fails multipath after boot up
Date: Mon, 9 Sep 2013 13:31:47 -0700 [thread overview]
Message-ID: <1378758713-22443-3-git-send-email-hiralpat@cisco.com> (raw)
In-Reply-To: <1378758713-22443-1-git-send-email-hiralpat@cisco.com>
From: Brian Uchino <buchino@cisco.com>
Issue was seen when SCSI buffer address is more than 40 bits in system
with more than 1.1TB RAM. When SCSI buffer is passed to VIC, it is failing
to map to correct buffer address, as DMA mask is set to 40 bits in driver
initialization. Corrected DMA_MASK from 40-bits to 64-bits to avoid masking
41-64 bits addresses.
Signed-off-by: Brian Uchino <buchino@cisco.com>
Signed-off-by: Hiral Patel <hiralpat@cisco.com>
---
drivers/scsi/fnic/fnic_main.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/scsi/fnic/fnic_main.c b/drivers/scsi/fnic/fnic_main.c
index b619dab..835a9cd 100644
--- a/drivers/scsi/fnic/fnic_main.c
+++ b/drivers/scsi/fnic/fnic_main.c
@@ -581,10 +581,10 @@ static int fnic_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
pci_set_master(pdev);
/* Query PCI controller on system for DMA addressing
- * limitation for the device. Try 40-bit first, and
+ * limitation for the device. Try 64-bit first, and
* fail to 32-bit.
*/
- err = pci_set_dma_mask(pdev, DMA_BIT_MASK(40));
+ err = pci_set_dma_mask(pdev, DMA_BIT_MASK(64));
if (err) {
err = pci_set_dma_mask(pdev, DMA_BIT_MASK(32));
if (err) {
@@ -601,10 +601,10 @@ static int fnic_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
goto err_out_release_regions;
}
} else {
- err = pci_set_consistent_dma_mask(pdev, DMA_BIT_MASK(40));
+ err = pci_set_consistent_dma_mask(pdev, DMA_BIT_MASK(64));
if (err) {
shost_printk(KERN_ERR, fnic->lport->host,
- "Unable to obtain 40-bit DMA "
+ "Unable to obtain 64-bit DMA "
"for consistent allocations, aborting.\n");
goto err_out_release_regions;
}
--
1.7.10.4
next prev parent reply other threads:[~2013-09-09 20:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-09 20:31 [PATCH 1/9] fnic: FC stat param seconds_since_last_reset not getting updated Hiral Patel
2013-09-09 20:31 ` [PATCH 2/9] fnic: host reset returns nonzero value(errno) on success Hiral Patel
2013-09-11 20:04 ` James Bottomley
2013-09-09 20:31 ` Hiral Patel [this message]
2013-09-09 20:31 ` [PATCH 4/9] fnic: Remove QUEUE_FULL handling code Hiral Patel
2013-09-09 20:31 ` [PATCH 5/9] fnic: Hitting BUG_ON(io_req->abts_done) in fnic_rport_exch_reset Hiral Patel
2013-09-09 20:31 ` [PATCH 6/9] fnic: Kernel panic while running sh/nosh with max lun cfg Hiral Patel
2013-09-09 20:31 ` [PATCH 7/9] fnic: fnic Driver Tuneables Exposed through CLI Hiral Patel
2013-09-09 20:31 ` [PATCH 8/9] fnic: Fnic Statistics Collection Hiral Patel
2013-09-11 23:11 ` James Bottomley
2013-09-09 20:31 ` [PATCH 9/9] fnic: Incremented driver version Hiral Patel
-- strict thread matches above, loose matches on Subject: below --
2013-08-29 17:57 [PATCH 1/9] fnic: FC stat param seconds_since_last_reset not getting updated Hiral Patel
2013-08-29 17:57 ` [PATCH 3/9] fnic: On system with >1.1TB RAM, VIC fails multipath after boot up Hiral Patel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1378758713-22443-3-git-send-email-hiralpat@cisco.com \
--to=hiralpat@cisco.com \
--cc=JBottomley@parallels.com \
--cc=buchino@cisco.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).