From: Hiral Patel <hiralpat@cisco.com>
To: linux-scsi@vger.kernel.org
Cc: JBottomley@parallels.com, Suma Ramars <sramars@cisco.com>,
Hiral Patel <hiralpat@cisco.com>
Subject: [PATCH 4/9] fnic: Remove QUEUE_FULL handling code
Date: Mon, 9 Sep 2013 13:31:48 -0700 [thread overview]
Message-ID: <1378758713-22443-4-git-send-email-hiralpat@cisco.com> (raw)
In-Reply-To: <1378758713-22443-1-git-send-email-hiralpat@cisco.com>
From: Suma Ramars <sramars@cisco.com>
Remove fnic driver QUEUE_FULL handling code instead let SCSI mid layer
handle queue full and use its algorithm to ramp down/up queue
Signed-off-by: Suma Ramars <sramars@cisco.com>
Signed-off-by: Hiral Patel <hiralpat@cisco.com>
---
drivers/scsi/fnic/fnic_scsi.c | 32 --------------------------------
1 file changed, 32 deletions(-)
diff --git a/drivers/scsi/fnic/fnic_scsi.c b/drivers/scsi/fnic/fnic_scsi.c
index ef3c463..a09dd8d 100644
--- a/drivers/scsi/fnic/fnic_scsi.c
+++ b/drivers/scsi/fnic/fnic_scsi.c
@@ -818,38 +818,6 @@ static void fnic_fcpio_icmnd_cmpl_handler(struct fnic *fnic,
if (icmnd_cmpl->flags & FCPIO_ICMND_CMPL_RESID_UNDER)
xfer_len -= icmnd_cmpl->residual;
- /*
- * If queue_full, then try to reduce queue depth for all
- * LUNS on the target. Todo: this should be accompanied
- * by a periodic queue_depth rampup based on successful
- * IO completion.
- */
- if (icmnd_cmpl->scsi_status == QUEUE_FULL) {
- struct scsi_device *t_sdev;
- int qd = 0;
-
- shost_for_each_device(t_sdev, sc->device->host) {
- if (t_sdev->id != sc->device->id)
- continue;
-
- if (t_sdev->queue_depth > 1) {
- qd = scsi_track_queue_full
- (t_sdev,
- t_sdev->queue_depth - 1);
- if (qd == -1)
- qd = t_sdev->host->cmd_per_lun;
- shost_printk(KERN_INFO,
- fnic->lport->host,
- "scsi[%d:%d:%d:%d"
- "] queue full detected,"
- "new depth = %d\n",
- t_sdev->host->host_no,
- t_sdev->channel,
- t_sdev->id, t_sdev->lun,
- t_sdev->queue_depth);
- }
- }
- }
break;
case FCPIO_TIMEOUT: /* request was timed out */
--
1.7.10.4
next prev parent reply other threads:[~2013-09-09 20:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-09 20:31 [PATCH 1/9] fnic: FC stat param seconds_since_last_reset not getting updated Hiral Patel
2013-09-09 20:31 ` [PATCH 2/9] fnic: host reset returns nonzero value(errno) on success Hiral Patel
2013-09-11 20:04 ` James Bottomley
2013-09-09 20:31 ` [PATCH 3/9] fnic: On system with >1.1TB RAM, VIC fails multipath after boot up Hiral Patel
2013-09-09 20:31 ` Hiral Patel [this message]
2013-09-09 20:31 ` [PATCH 5/9] fnic: Hitting BUG_ON(io_req->abts_done) in fnic_rport_exch_reset Hiral Patel
2013-09-09 20:31 ` [PATCH 6/9] fnic: Kernel panic while running sh/nosh with max lun cfg Hiral Patel
2013-09-09 20:31 ` [PATCH 7/9] fnic: fnic Driver Tuneables Exposed through CLI Hiral Patel
2013-09-09 20:31 ` [PATCH 8/9] fnic: Fnic Statistics Collection Hiral Patel
2013-09-11 23:11 ` James Bottomley
2013-09-09 20:31 ` [PATCH 9/9] fnic: Incremented driver version Hiral Patel
-- strict thread matches above, loose matches on Subject: below --
2013-08-29 17:57 [PATCH 1/9] fnic: FC stat param seconds_since_last_reset not getting updated Hiral Patel
2013-08-29 17:57 ` [PATCH 4/9] fnic: Remove QUEUE_FULL handling code Hiral Patel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1378758713-22443-4-git-send-email-hiralpat@cisco.com \
--to=hiralpat@cisco.com \
--cc=JBottomley@parallels.com \
--cc=linux-scsi@vger.kernel.org \
--cc=sramars@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).