From: Oliver Neukum <oneukum@suse.de>
To: hare@suse.de
Cc: Alan Stern <stern@rowland.harvard.edu>, linux-scsi@vger.kernel.org
Subject: READ_CAPACITY_16 vs. READ_CAPACITY_10
Date: Tue, 10 Sep 2013 15:56:48 +0200 [thread overview]
Message-ID: <1378821408.13541.26.camel@linux-fkkt.site> (raw)
Hi Hannes,
you objected to this patch saying there's a possibilty that
HS devices may also need this feature, which would require
a quirk. Does this mean that the patch is acceptable only
with an additional predefined quirk, or do you insist that all
devices be handled with quirks?
Regards
Oliver
+++ b/drivers/usb/storage/scsiglue.c
@@ -211,8 +211,11 @@ static int slave_configure(struct
scsi_device0*sdev)
/*
* Many devices do not respond properly to READ_CAPACITY_16.
* Tell the SCSI layer to try READ_CAPACITY_10 first.
+ * However some USB 3.0 drive enclosures return capacity
+ * modulo 2TB
*/
- sdev->try_rc_10_first = 1;
+ if (us->pusb_dev->speed < USB_SPEED_SUPER)
+ sdev->try_rc_10_first = 1;
/* assume SPC3 or latter devices support sense size > 18 */
if (sdev->scsi_level > SCSI_SPC_2)
next reply other threads:[~2013-09-10 13:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-10 13:56 Oliver Neukum [this message]
2013-09-10 17:25 ` READ_CAPACITY_16 vs. READ_CAPACITY_10 Alan Stern
2013-09-10 20:44 ` Oliver Neukum
2013-09-11 14:14 ` Alan Stern
2013-09-11 15:05 ` Oliver Neukum
2013-09-11 15:42 ` Alan Stern
2013-09-11 15:56 ` Steve Magnani
2013-09-12 5:47 ` Hannes Reinecke
2013-09-16 12:41 ` Oliver Neukum
2013-09-12 5:56 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1378821408.13541.26.camel@linux-fkkt.site \
--to=oneukum@suse.de \
--cc=hare@suse.de \
--cc=linux-scsi@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).