From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-scsi <linux-scsi@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PULL] SCSI fixes for 3.12-rc6
Date: Wed, 23 Oct 2013 13:19:50 +0100 [thread overview]
Message-ID: <1382530790.16097.29.camel@dabdike.quadriga.com> (raw)
In-Reply-To: <CA+55aFzo-sA4P_rMC1wWfLp50QswfP0GdLxMQ+Wbw8ArK5capw@mail.gmail.com>
On Wed, 2013-10-23 at 13:07 +0100, Linus Torvalds wrote:
> On Wed, Oct 23, 2013 at 12:27 PM, James Bottomley
> <James.Bottomley@hansenpartnership.com> wrote:
> >
> > The patch is available here:
> >
> > git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git scsi-fixes
>
> No it's not. "Already up-to-date.".
Um, sorry, forgot to make a tag. Done now.
> Also, even if it was, I'm not feeling the reason to pull it. "Cleanup
> sprintf formatting of firmware version"? "Remove superfluous mask of
> pcie_cap_reg"? Seriously?
Well, yes, provided the new driver exception still holds. The eas2r
driver was added in the last merge window so it qualifies. Previously
you'd said that drivers that weren't previously in the tree could have
changes and cleanups added even at the -rc stage ... if you're reversing
this, I can pull the eas2r updates into the misc tree insead.
> Multi-hundred-line pull requests that come in this late had better
> look a bit more serious than that.
>
> There's *HUNDREDS* of lines of changes, all of which seems to come
> from the change to use the (admittedly much superior) native bit
> handling fucntions, instead of the shit-for-brains abortion that is
> "esas2r_lock_set/clear_flags()"
>
> And I see why you'd want to get rid of that horrible crap, but I see
> absolutely _zero_ reason to do it in -rc7.
>
> As far as I can tell from the patch, a few lines are for actual
> problems like oopses. And the rest is pure and utter garbage that
> should have happened during the merge window.
>
> So I literally *cannot* pull this, because the git tree doesn't
> contain what you said it contains. But even if it did, I would not
> *want* to pull this kind of completely brainless crap.
>
> You need to curse at the people who send you this kind of crap.
> Seriously. This is not acceptablee timing.
OK, so is the new driver exception gone then?
James
next prev parent reply other threads:[~2013-10-23 12:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-23 11:27 [GIT PULL] SCSI fixes for 3.12-rc6 James Bottomley
2013-10-23 12:07 ` Linus Torvalds
2013-10-23 12:19 ` James Bottomley [this message]
2013-10-23 12:42 ` Linus Torvalds
2013-10-23 14:07 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1382530790.16097.29.camel@dabdike.quadriga.com \
--to=james.bottomley@hansenpartnership.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox