From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Dave Jones <davej@redhat.com>
Cc: linux-scsi@vger.kernel.org
Subject: Re: self assignment bug in aix94xx
Date: Thu, 24 Oct 2013 10:03:10 +0100 [thread overview]
Message-ID: <1382605390.2559.12.camel@dabdike.quadriga.com> (raw)
In-Reply-To: <20131024085512.GB15720@redhat.com>
On Thu, 2013-10-24 at 04:55 -0400, Dave Jones wrote:
> 2908d778 (James Bottomley 2006-08-29 09:22:51 -0500 515) scb->ssp_task.retry_count = scb->ssp_task.retry_count;
>
> Is this supposed to maybe be..
>
> scb->ssp_task.retry_count = task->ssp_task.retry_count;
>
> ?
Oh, boy, this was the master commit for aic94xx (so it's not me it was a
bunch of people working on the driver). I'll see if I can analyse the
logic flow to find out what should have been going on, but it will take
a couple of weeks.
> (This and a whole bunch of similar bugs found with Coverity.)
May as well send them along and I'll look at them too.
James
> Dave
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2013-10-24 9:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-24 8:55 self assignment bug in aix94xx Dave Jones
2013-10-24 9:03 ` James Bottomley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1382605390.2559.12.camel@dabdike.quadriga.com \
--to=james.bottomley@hansenpartnership.com \
--cc=davej@redhat.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox