Re: [PATCH v3 3/4] ata: Add APM X-Gene SoC SATA host controller driver

Loc Ho
2013-11-26T16:41:01Z

Hi,

>> int set_speed(struct *phy, int lane, u64 speed);
>
> it should be phy_set_speed.
[Loc Ho]
But your other functions don't repeat the prefix "phy"?

>>
>> where lane indicates the lane of the PHY and speed is the PHY speed in hertz.
>
> Does lane here means the number of lanes? Is the lane also obtained after the
> training sequence?
[Loc Ho]
Lane here is the lane with you are changing the speed. If there are
two lanes, then 0 parameter would change lane 0. 1 would change lane
1.

-Loc