Re: [PATCH v3 3/4] ata: Add APM X-Gene SoC SATA host controller driver

Loc Ho
2013-11-21T19:01:05Z

Hi,

>> >> diff --git a/drivers/ata/sata_xgene.h b/drivers/ata/sata_xgene.h
>> >> new file mode 100644
>> >> index 0000000..51e73f6
>> >> --- /dev/null
>> >> +++ b/drivers/ata/sata_xgene.h
>> >
>> > This file should probably just be folded into the driver, since it contains no
>> > interfaces between modules, just internal definitions.
>> [Loc Ho]
>> I can get rip this header file now. But in the future I may need to
>> add this back as I intended this driver to also support running from
>> our co-processor (ARMv7 32-bit). For that, I will need anothe file and
>> other function that will need knowledge of the context structure and
>> etc.
>
> Hmm, is the code for that coprocessor compiled from the kernel source?
> If not, it shouldn't really make a difference as it won't live in a shared
> code repository.
>
[Loc Ho]
The co-processors are just ARM based core and the same kernel can be
build to support it. Let's not worry about this yet.

-Loc