From: Oliver Neukum <oliver@neukum.org>
To: "Geyslan Gregório Bem" <geyslan@gmail.com>
Cc: Ali Akcaagac <aliakc@web.de>, Jamie Lenehan <lenehan@twibble.org>,
"James E.J. Bottomley" <JBottomley@parallels.com>,
dc395x@twibble.org, LKML <linux-kernel@vger.kernel.org>,
linux-scsi@vger.kernel.org, hch@infradead.org
Subject: Re: [RFC] drivers/scsi/dc395x.c - msgin_qtag()
Date: Mon, 18 Nov 2013 08:53:40 +0100 [thread overview]
Message-ID: <1384761220.30084.9.camel@linux-fkkt.site> (raw)
In-Reply-To: <CAGG-pUSG0sngtW_F3j=Koa1KmjsLKE-2RU9Jy5Zm_=eUoe5rOg@mail.gmail.com>
On Fri, 2013-11-15 at 17:53 -0200, Geyslan Gregório Bem wrote:
Hi,
> Hi guys,
>
> In the function msgin_qtag() [line 2632], this dereference was intentional?
>
> static struct ScsiReqBlk *msgin_qtag(struct AdapterCtlBlk *acb,
> struct DeviceCtlBlk *dcb, u8 tag)
> {
> struct ScsiReqBlk *srb = NULL;
> struct ScsiReqBlk *i;
> dprintkdbg(DBG_0, "msgin_qtag: (0x%p) tag=%i srb=%p\n",
> srb->cmd, tag, srb);
> ...
>
> There is a srb (NULL) dereference in the dprintkdbg() parameteres.
That is a bad bug.
> If not, what approach do you suggest me for a patch?
Merge it with
dprintkdbg(DBG_0, "msgin_qtag: (0x%p) <%02i-%i>\n",
srb->cmd, srb->dcb->target_id, srb->dcb->target_lun);
later in the function.
Regards
Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2013-11-18 7:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-15 19:53 [RFC] drivers/scsi/dc395x.c - msgin_qtag() Geyslan Gregório Bem
2013-11-18 7:53 ` Oliver Neukum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1384761220.30084.9.camel@linux-fkkt.site \
--to=oliver@neukum.org \
--cc=JBottomley@parallels.com \
--cc=aliakc@web.de \
--cc=dc395x@twibble.org \
--cc=geyslan@gmail.com \
--cc=hch@infradead.org \
--cc=lenehan@twibble.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox