linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hannes Reinecke <hare@suse.de>
To: James Bottomley <jbottomley@parallels.com>
Cc: linux-scsi@vger.kernel.org, Hannes Reinecke <hare@suse.de>
Subject: [PATCH 1/5] scsi: Remove CONFIG_SCSI_MULTI_LUN
Date: Tue, 10 Dec 2013 12:05:11 +0100	[thread overview]
Message-ID: <1386673515-87133-2-git-send-email-hare@suse.de> (raw)
In-Reply-To: <1386673515-87133-1-git-send-email-hare@suse.de>

Obsolete; either use 'max_lun' if the host supports only a
limited number of LUNs or BLIST_NOLUN if the target has
problems addressing more than one LUN.

Signed-off-by: Hannes Reinecke <hare@suse.de>
---
 drivers/scsi/Kconfig     | 14 --------------
 drivers/scsi/dc395x.c    |  9 +--------
 drivers/scsi/ncr53c8xx.h |  4 ----
 drivers/scsi/scsi_scan.c |  4 ----
 4 files changed, 1 insertion(+), 30 deletions(-)

diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
index 1f02003..900c7d90 100644
--- a/drivers/scsi/Kconfig
+++ b/drivers/scsi/Kconfig
@@ -197,20 +197,6 @@ config SCSI_ENCLOSURE
 	  it has an enclosure device.  Selecting this option will just allow
 	  certain enclosure conditions to be reported and is not required.
 
-config SCSI_MULTI_LUN
-	bool "Probe all LUNs on each SCSI device"
-	depends on SCSI
-	help
-	  Some devices support more than one LUN (Logical Unit Number) in order
-	  to allow access to several media, e.g. CD jukebox, USB card reader,
-	  mobile phone in mass storage mode. This option forces the kernel to
-	  probe for all LUNs by default. This setting can be overriden by
-	  max_luns boot/module parameter. Note that this option does not affect
-	  devices conforming to SCSI-3 or higher as they can explicitely report
-	  their number of LUNs. It is safe to say Y here unless you have one of
-	  those rare devices which reacts in an unexpected way when probed for
-	  multiple LUNs.
-
 config SCSI_CONSTANTS
 	bool "Verbose SCSI error reporting (kernel size +=12K)"
 	depends on SCSI
diff --git a/drivers/scsi/dc395x.c b/drivers/scsi/dc395x.c
index 83d9bf6..ad7bee0 100644
--- a/drivers/scsi/dc395x.c
+++ b/drivers/scsi/dc395x.c
@@ -519,9 +519,7 @@ static struct ParameterData cfg_data[] = {
 		CFG_PARAM_UNSET,
 		0,
 		0x2f,
-#ifdef CONFIG_SCSI_MULTI_LUN
-			NAC_SCANLUN |
-#endif
+		NAC_SCANLUN |
 		NAC_GT2DRIVES | NAC_GREATER_1G | NAC_POWERON_SCSI_RESET
 			/*| NAC_ACTIVE_NEG*/,
 		NAC_GT2DRIVES | NAC_GREATER_1G | NAC_POWERON_SCSI_RESET | 0x08
@@ -4434,15 +4432,10 @@ static void adapter_init_scsi_host(struct Scsi_Host *host)
 	if (host->max_id - 1 == eeprom->scsi_id)
 		host->max_id--;
 
-#ifdef CONFIG_SCSI_MULTI_LUN
 	if (eeprom->channel_cfg & NAC_SCANLUN)
 		host->max_lun = 8;
 	else
 		host->max_lun = 1;
-#else
-	host->max_lun = 1;
-#endif
-
 }
 
 
diff --git a/drivers/scsi/ncr53c8xx.h b/drivers/scsi/ncr53c8xx.h
index 0e008da..02901c5 100644
--- a/drivers/scsi/ncr53c8xx.h
+++ b/drivers/scsi/ncr53c8xx.h
@@ -264,11 +264,7 @@
 #define SCSI_NCR_SG_TABLESIZE	(SCSI_NCR_MAX_SCATTER)
 #define SCSI_NCR_TIMER_INTERVAL	(HZ)
 
-#if 1 /* defined CONFIG_SCSI_MULTI_LUN */
 #define SCSI_NCR_MAX_LUN	(16)
-#else
-#define SCSI_NCR_MAX_LUN	(1)
-#endif
 
 /*
  *  IO functions definition for big/little endian CPU support.
diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c
index 307a811..e289fb3 100644
--- a/drivers/scsi/scsi_scan.c
+++ b/drivers/scsi/scsi_scan.c
@@ -81,11 +81,7 @@ static const char *scsi_null_device_strs = "nullnullnullnull";
 
 #define MAX_SCSI_LUNS	512
 
-#ifdef CONFIG_SCSI_MULTI_LUN
 static unsigned int max_scsi_luns = MAX_SCSI_LUNS;
-#else
-static unsigned int max_scsi_luns = 1;
-#endif
 
 module_param_named(max_luns, max_scsi_luns, uint, S_IRUGO|S_IWUSR);
 MODULE_PARM_DESC(max_luns,
-- 
1.7.12.4


  reply	other threads:[~2013-12-10 11:05 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-10 11:05 [PATCH 0/5][RFC] Support 64-bit LUNs Hannes Reinecke
2013-12-10 11:05 ` Hannes Reinecke [this message]
2014-03-27 14:47   ` [PATCH 1/5] scsi: Remove CONFIG_SCSI_MULTI_LUN Christoph Hellwig
2013-12-10 11:05 ` [PATCH 2/5] scsi_scan: Restrict sequential scan to 256 LUNs Hannes Reinecke
2014-03-27 14:49   ` Christoph Hellwig
2014-03-28  8:22     ` Hannes Reinecke
2014-03-28 12:47       ` Christoph Hellwig
2014-03-28 13:19         ` Hannes Reinecke
2013-12-10 11:05 ` [PATCH 3/5] qla2xxx: Restrict max_luns to 16-bit for older HBAs Hannes Reinecke
2013-12-10 18:26   ` Chad Dupuis
2014-05-15  6:38     ` Christoph Hellwig
2014-05-15  8:47       ` Hannes Reinecke
2013-12-10 11:05 ` [PATCH 4/5] scsi: use 64-bit LUNs Hannes Reinecke
2014-03-27 14:52   ` Christoph Hellwig
2013-12-10 11:05 ` [PATCH 5/5] scsi: use 64-bit value for 'max_luns' Hannes Reinecke
2014-03-27 14:52   ` Christoph Hellwig
2014-05-15  6:38 ` [PATCH 0/5][RFC] Support 64-bit LUNs Christoph Hellwig
2014-05-15  6:57   ` Hannes Reinecke
  -- strict thread matches above, loose matches on Subject: below --
2014-05-20 11:03 [PATCHv2 0/5] " Hannes Reinecke
2014-05-20 11:03 ` [PATCH 1/5] scsi: Remove CONFIG_SCSI_MULTI_LUN Hannes Reinecke
2014-05-22  9:07   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1386673515-87133-2-git-send-email-hare@suse.de \
    --to=hare@suse.de \
    --cc=jbottomley@parallels.com \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).