From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: james.smart@emulex.com
Cc: linux-scsi@vger.kernel.org
Subject: Re: [PATCH 1/7] lpfc 8.3.44: Fixed IO hang when in msi mode.
Date: Tue, 17 Dec 2013 12:30:44 -0800 [thread overview]
Message-ID: <1387312244.2213.76.camel@dabdike.int.hansenpartnership.com> (raw)
In-Reply-To: <1386006499.11046.9.camel@myfc17>
On Mon, 2013-12-02 at 12:48 -0500, James Smart wrote:
> Fixed IO hang when in msi mode.
>
>
> Signed-off-by: James Smart <james.smart@emulex.com>
There seems to be a lot of tab vs space checkpatch warnings in this
series:
ERROR: code indent should use tabs where possible
#24: FILE: drivers/scsi/lpfc/lpfc_scsi.c:4792:
+ cmnd->device ? cmnd->device->lun :
0xffff,$
WARNING: please, no spaces at the start of a line
#24: FILE: drivers/scsi/lpfc/lpfc_scsi.c:4792:
+ cmnd->device ? cmnd->device->lun :
0xffff,$
ERROR: code indent should use tabs where possible
#25: FILE: drivers/scsi/lpfc/lpfc_scsi.c:4793:
+ vport->fc_myDID, ndlp->nlp_DID,$
WARNING: please, no spaces at the start of a line
#25: FILE: drivers/scsi/lpfc/lpfc_scsi.c:4793:
+ vport->fc_myDID, ndlp->nlp_DID,$
ERROR: code indent should use tabs where possible
#26: FILE: drivers/scsi/lpfc/lpfc_scsi.c:4794:
+ phba->sli_rev == LPFC_SLI_REV4 ?$
WARNING: please, no spaces at the start of a line
#26: FILE: drivers/scsi/lpfc/lpfc_scsi.c:4794:
+ phba->sli_rev == LPFC_SLI_REV4 ?$
ERROR: code indent should use tabs where possible
#27: FILE: drivers/scsi/lpfc/lpfc_scsi.c:4795:
+ lpfc_cmd->cur_iocbq.sli4_xritag :
0xffff,$
WARNING: please, no spaces at the start of a line
#27: FILE: drivers/scsi/lpfc/lpfc_scsi.c:4795:
+ lpfc_cmd->cur_iocbq.sli4_xritag :
0xffff,$
ERROR: code indent should use tabs where possible
#28: FILE: drivers/scsi/lpfc/lpfc_scsi.c:4796:
+ lpfc_cmd->cur_iocbq.iocb.ulpContext,$
WARNING: please, no spaces at the start of a line
#28: FILE: drivers/scsi/lpfc/lpfc_scsi.c:4796:
+ lpfc_cmd->cur_iocbq.iocb.ulpContext,$
ERROR: code indent should use tabs where possible
#29: FILE: drivers/scsi/lpfc/lpfc_scsi.c:4797:
+ lpfc_cmd->cur_iocbq.iocb.ulpIoTag,$
WARNING: please, no spaces at the start of a line
#29: FILE: drivers/scsi/lpfc/lpfc_scsi.c:4797:
+ lpfc_cmd->cur_iocbq.iocb.ulpIoTag,$
ERROR: code indent should use tabs where possible
#30: FILE: drivers/scsi/lpfc/lpfc_scsi.c:4798:
+ lpfc_cmd->cur_iocbq.iocb.ulpTimeout,$
WARNING: please, no spaces at the start of a line
#30: FILE: drivers/scsi/lpfc/lpfc_scsi.c:4798:
+ lpfc_cmd->cur_iocbq.iocb.ulpTimeout,$
ERROR: code indent should use tabs where possible
#31: FILE: drivers/scsi/lpfc/lpfc_scsi.c:4799:
+ (uint32_t)$
WARNING: please, no spaces at the start of a line
#31: FILE: drivers/scsi/lpfc/lpfc_scsi.c:4799:
+ (uint32_t)$
ERROR: code indent should use tabs where possible
#32: FILE: drivers/scsi/lpfc/lpfc_scsi.c:4800:
+ (cmnd->request->timeout / 1000));$
WARNING: please, no spaces at the start of a line
#32: FILE: drivers/scsi/lpfc/lpfc_scsi.c:4800:
+ (cmnd->request->timeout / 1000));$
total: 9 errors, 9 warnings, 33 lines checked
NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch
or
scripts/cleanfile
I don't think it's your mailer otherwise the patch wouldn't have
applied. Could you fix and resend the series?
Thanks,
James
next prev parent reply other threads:[~2013-12-17 20:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-02 17:48 [PATCH 1/7] lpfc 8.3.44: Fixed IO hang when in msi mode James Smart
2013-12-17 20:30 ` James Bottomley [this message]
2013-12-17 21:08 ` James Smart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1387312244.2213.76.camel@dabdike.int.hansenpartnership.com \
--to=james.bottomley@hansenpartnership.com \
--cc=james.smart@emulex.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox