From: michaelc@cs.wisc.edu
To: linux-scsi@vger.kernel.org
Subject: [PATCH 3/6] SCSI/libiscsi: Remove unneeded code
Date: Fri, 20 Dec 2013 12:53:44 -0600 [thread overview]
Message-ID: <1387565627-5218-4-git-send-email-michaelc@cs.wisc.edu> (raw)
In-Reply-To: <1387565627-5218-1-git-send-email-michaelc@cs.wisc.edu>
From: Shlomo Pongratz <shlomop@mellanox.com>
We never will have a closed window and something on one of those lists.
Signed-off-by: Mike Christie <michaelc@cs.wisc.edu>
Signed-off-by: Shlomo Pongratz <shlomop@mellanox.com>
---
drivers/scsi/libiscsi.c | 12 ------------
1 files changed, 0 insertions(+), 12 deletions(-)
diff --git a/drivers/scsi/libiscsi.c b/drivers/scsi/libiscsi.c
index e77c41f..cc19cc2 100644
--- a/drivers/scsi/libiscsi.c
+++ b/drivers/scsi/libiscsi.c
@@ -108,18 +108,6 @@ static void __iscsi_update_cmdsn(struct iscsi_session *session,
if (exp_cmdsn != session->exp_cmdsn &&
!iscsi_sna_lt(exp_cmdsn, session->exp_cmdsn))
session->exp_cmdsn = exp_cmdsn;
-
- if (max_cmdsn != session->max_cmdsn &&
- !iscsi_sna_lt(max_cmdsn, session->max_cmdsn)) {
- session->max_cmdsn = max_cmdsn;
- /*
- * if the window closed with IO queued, then kick the
- * xmit thread
- */
- if (!list_empty(&session->leadconn->cmdqueue) ||
- !list_empty(&session->leadconn->mgmtqueue))
- iscsi_conn_queue_work(session->leadconn);
- }
}
void iscsi_update_cmdsn(struct iscsi_session *session, struct iscsi_nopin *hdr)
--
1.7.1
next prev parent reply other threads:[~2013-12-20 18:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-20 18:53 [PATCH 0/6] iscsi changes for scsi-misc michaelc
2013-12-20 18:53 ` [PATCH 1/6] SCSI/libiscsi: Restructure iscsi_tcp r2t response logic michaelc
2013-12-20 18:53 ` [PATCH 2/6] SCSI/libiscsi: Reduce locking contention in fast path michaelc
2014-01-17 8:11 ` Mike Christie
2013-12-20 18:53 ` michaelc [this message]
2013-12-20 18:53 ` [PATCH 4/6] be2iscsi: fix lun test in device reset callout michaelc
2013-12-20 18:53 ` [PATCH 5/6] iscsi_boot_sysfs: Fix a memory leak in iscsi_boot_destroy_kset() michaelc
2013-12-20 18:53 ` [PATCH 6/6] iscsi_tcp: check for valid session before accessing michaelc
2014-02-07 2:20 ` [PATCH 0/6] iscsi changes for scsi-misc Mike Christie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1387565627-5218-4-git-send-email-michaelc@cs.wisc.edu \
--to=michaelc@cs.wisc.edu \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).