linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: michaelc@cs.wisc.edu
To: linux-scsi@vger.kernel.org
Subject: [PATCH 5/6] iscsi_boot_sysfs: Fix a memory leak in iscsi_boot_destroy_kset()
Date: Fri, 20 Dec 2013 12:53:46 -0600	[thread overview]
Message-ID: <1387565627-5218-6-git-send-email-michaelc@cs.wisc.edu> (raw)
In-Reply-To: <1387565627-5218-1-git-send-email-michaelc@cs.wisc.edu>

From: Ethan Zhao <ethan.kernel@gmail.com>

Load and unload iscsi_ibft module will cause kernel memory leak, fix it
in scsi/iscsi_boot_sysfs.c iscsi_boot_destroy_kset().

Signed-off-by: Ethan Zhao <ethan.kernel@gmail.com>
Signed-off-by: Mike Christie <michaelc@cs.wisc.edu>
---
 drivers/scsi/iscsi_boot_sysfs.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/scsi/iscsi_boot_sysfs.c b/drivers/scsi/iscsi_boot_sysfs.c
index 14c1c8f..680bf6f 100644
--- a/drivers/scsi/iscsi_boot_sysfs.c
+++ b/drivers/scsi/iscsi_boot_sysfs.c
@@ -490,5 +490,6 @@ void iscsi_boot_destroy_kset(struct iscsi_boot_kset *boot_kset)
 		iscsi_boot_remove_kobj(boot_kobj);
 
 	kset_unregister(boot_kset->kset);
+	kfree(boot_kset);
 }
 EXPORT_SYMBOL_GPL(iscsi_boot_destroy_kset);
-- 
1.7.1


  parent reply	other threads:[~2013-12-20 18:54 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-20 18:53 [PATCH 0/6] iscsi changes for scsi-misc michaelc
2013-12-20 18:53 ` [PATCH 1/6] SCSI/libiscsi: Restructure iscsi_tcp r2t response logic michaelc
2013-12-20 18:53 ` [PATCH 2/6] SCSI/libiscsi: Reduce locking contention in fast path michaelc
2014-01-17  8:11   ` Mike Christie
2013-12-20 18:53 ` [PATCH 3/6] SCSI/libiscsi: Remove unneeded code michaelc
2013-12-20 18:53 ` [PATCH 4/6] be2iscsi: fix lun test in device reset callout michaelc
2013-12-20 18:53 ` michaelc [this message]
2013-12-20 18:53 ` [PATCH 6/6] iscsi_tcp: check for valid session before accessing michaelc
2014-02-07  2:20 ` [PATCH 0/6] iscsi changes for scsi-misc Mike Christie
  -- strict thread matches above, loose matches on Subject: below --
2014-02-07  6:41 [PATCH 0/6]: iscsi changes for scsi-misc (v2) michaelc
2014-02-07  6:41 ` [PATCH 5/6] iscsi_boot_sysfs: Fix a memory leak in iscsi_boot_destroy_kset() michaelc

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1387565627-5218-6-git-send-email-michaelc@cs.wisc.edu \
    --to=michaelc@cs.wisc.edu \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).