From: michaelc@cs.wisc.edu
To: linux-scsi@vger.kernel.org
Subject: [PATCH 6/6] iscsi_tcp: check for valid session before accessing
Date: Fri, 20 Dec 2013 12:53:47 -0600 [thread overview]
Message-ID: <1387565627-5218-7-git-send-email-michaelc@cs.wisc.edu> (raw)
In-Reply-To: <1387565627-5218-1-git-send-email-michaelc@cs.wisc.edu>
From: Mike Christie <michaelc@cs.wisc.edu>
Check that the session is setup before accessing its
connection. This fixes a oops where userspace tries
to get the ip address before the session is bound to
a host.
Signed-off-by: Mike Christie <michaelc@cs.wisc.edu>
---
drivers/scsi/iscsi_tcp.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/scsi/iscsi_tcp.c b/drivers/scsi/iscsi_tcp.c
index 12b3512..bfb6d07 100644
--- a/drivers/scsi/iscsi_tcp.c
+++ b/drivers/scsi/iscsi_tcp.c
@@ -759,6 +759,9 @@ static int iscsi_sw_tcp_host_get_param(struct Scsi_Host *shost,
switch (param) {
case ISCSI_HOST_PARAM_IPADDRESS:
+ if (!session)
+ return -ENOTCONN;
+
spin_lock_bh(&session->frwd_lock);
conn = session->leadconn;
if (!conn) {
--
1.7.1
next prev parent reply other threads:[~2013-12-20 18:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-20 18:53 [PATCH 0/6] iscsi changes for scsi-misc michaelc
2013-12-20 18:53 ` [PATCH 1/6] SCSI/libiscsi: Restructure iscsi_tcp r2t response logic michaelc
2013-12-20 18:53 ` [PATCH 2/6] SCSI/libiscsi: Reduce locking contention in fast path michaelc
2014-01-17 8:11 ` Mike Christie
2013-12-20 18:53 ` [PATCH 3/6] SCSI/libiscsi: Remove unneeded code michaelc
2013-12-20 18:53 ` [PATCH 4/6] be2iscsi: fix lun test in device reset callout michaelc
2013-12-20 18:53 ` [PATCH 5/6] iscsi_boot_sysfs: Fix a memory leak in iscsi_boot_destroy_kset() michaelc
2013-12-20 18:53 ` michaelc [this message]
2014-02-07 2:20 ` [PATCH 0/6] iscsi changes for scsi-misc Mike Christie
-- strict thread matches above, loose matches on Subject: below --
2014-02-07 6:41 [PATCH 0/6]: iscsi changes for scsi-misc (v2) michaelc
2014-02-07 6:41 ` [PATCH 6/6] iscsi_tcp: check for valid session before accessing michaelc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1387565627-5218-7-git-send-email-michaelc@cs.wisc.edu \
--to=michaelc@cs.wisc.edu \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).