From mboxrd@z Thu Jan 1 00:00:00 1970 From: James Bottomley Subject: Re: [RFC 0/2] target refcounting infrastructure fixes for usb Date: Thu, 02 Jan 2014 16:34:31 -0800 Message-ID: <1388709271.2399.30.camel@dabdike.int.hansenpartnership.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-15" Content-Transfer-Encoding: 7bit Return-path: Received: from bedivere.hansenpartnership.com ([66.63.167.143]:38714 "EHLO bedivere.hansenpartnership.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752709AbaACAed (ORCPT ); Thu, 2 Jan 2014 19:34:33 -0500 In-Reply-To: Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Alan Stern Cc: Sarah Sharp , linux-scsi , USB list On Sat, 2013-12-21 at 15:51 -0500, Alan Stern wrote: > On Fri, 20 Dec 2013, Sarah Sharp wrote: > > > On Thu, Dec 19, 2013 at 11:48:47AM -0800, James Bottomley wrote: > > > It should apply incrementally on top of the previous two. If it > > > actually works, I'll fold it into the first patch. > > > > Well, it doesn't oops anymore, but it does generate a pile of warnings: > > This was a simple oversight. scsi_target_reap() was called at the > start of __scsi_remove_device(), but it should be called at the end. > The patch below, applied on top of James's three patches, will fix the > warnings. Thanks, I'll do a repost of the combined series > Alan Stern > > P.S.: The comment isn't entirely correct any more... Yes, fixed the tense. James