From mboxrd@z Thu Jan 1 00:00:00 1970 From: Akinobu Mita Subject: [PATCH v2 3/7] scsi_debug: fix duplicate dif_errors increment Date: Sun, 19 Jan 2014 22:51:39 +0900 Message-ID: <1390139503-11519-4-git-send-email-akinobu.mita@gmail.com> References: <1390139503-11519-1-git-send-email-akinobu.mita@gmail.com> Return-path: Received: from mail-pa0-f53.google.com ([209.85.220.53]:35393 "EHLO mail-pa0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752324AbaASNv7 (ORCPT ); Sun, 19 Jan 2014 08:51:59 -0500 Received: by mail-pa0-f53.google.com with SMTP id lj1so5958121pab.12 for ; Sun, 19 Jan 2014 05:51:59 -0800 (PST) In-Reply-To: <1390139503-11519-1-git-send-email-akinobu.mita@gmail.com> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: linux-scsi@vger.kernel.org Cc: Akinobu Mita , "James E.J. Bottomley" , Douglas Gilbert , "Martin K. Petersen" It is unnecessary to increase dif_errors in dif_verify(), because the caller will increment it when dif_verify() detects failure. This bug was introduced by commit beb40ea42bd6 ("[SCSI] scsi_debug: reduce duplication between prot_verify_read and prot_verify_write") Signed-off-by: Akinobu Mita Acked-by: Martin K. Petersen Cc: "James E.J. Bottomley" Cc: Douglas Gilbert Cc: "Martin K. Petersen" Cc: linux-scsi@vger.kernel.org --- No change from previous version drivers/scsi/scsi_debug.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/scsi/scsi_debug.c b/drivers/scsi/scsi_debug.c index 9cd211e..1a42880 100644 --- a/drivers/scsi/scsi_debug.c +++ b/drivers/scsi/scsi_debug.c @@ -1780,7 +1780,6 @@ static int dif_verify(struct sd_dif_tuple *sdt, const void *data, be32_to_cpu(sdt->ref_tag) != ei_lba) { pr_err("%s: REF check failed on sector %lu\n", __func__, (unsigned long)sector); - dif_errors++; return 0x03; } return 0; -- 1.8.3.2