From: Vaughan Cao <vaughan.cao@oracle.com>
To: hare@suse.de
Cc: linux-scsi@vger.kernel.org, vaughan.cao@oracle.com,
jbottomley@parallels.com, sean.stewart@netapp.com,
marting@netapp.com
Subject: Re: [PATCH 16/16] scsi_dh_alua: Use workqueue for RTPG
Date: Tue, 21 Jan 2014 16:25:47 +0800 [thread overview]
Message-ID: <1390292747-8412-1-git-send-email-vaughan.cao@oracle.com> (raw)
In-Reply-To: <1387541621-54967-17-git-send-email-hare@suse.de>
On Fri, Dec 20, 2013 at 8:13 PM, Hannes Reinecke <hare@suse.de> wrote:
>
> +static void alua_rtpg_work(struct work_struct *work)
> +{
> ..........
> + if (pg->flags & ALUA_PG_RUN_STPG) {
> + spin_unlock_irqrestore(&pg->rtpg_lock, flags);
> + err = alua_stpg(sdev, pg);
> + spin_lock_irqsave(&pg->rtpg_lock, flags);
> + pg->flags &= ~ALUA_PG_RUN_STPG;
> + pg->flags |= ALUA_PG_STPG_DONE;
> + if (err == SCSI_DH_RETRY) {
> + pg->flags |= ALUA_PG_RUN_RTPG;
> + pg->interval = ALUA_RTPG_DELAY_MSECS * 1000;
>
Is the line above a typo?
pg->interval is measured in second unit. You won't want to set it as
milliseconds*1000. And ALUA_RTPG_DELAY_MSECS is used for queueing delayed rtpg
work, not for delay in retry cases such as state of transitioning. What you
want may be set a new delay time to start, similar to "pg->interval += 2" in
alua_rtpg when state of transitioning is returned.
Thanks,
Vaughan
next prev parent reply other threads:[~2014-01-21 8:25 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-20 12:13 [PATCH 00/16] scsi_dh_alua updates Hannes Reinecke
2013-12-20 12:13 ` [PATCH 01/16] scsi_dh_alua: Improve error handling Hannes Reinecke
2013-12-20 12:13 ` [PATCH 02/16] scsi_dh_alua: use flag for RTPG extended header Hannes Reinecke
2013-12-20 12:13 ` [PATCH 03/16] scsi_dh_alua: Pass buffer as function argument Hannes Reinecke
2013-12-20 12:13 ` [PATCH 04/16] scsi_dh_alua: Make stpg synchronous Hannes Reinecke
2013-12-20 12:13 ` [PATCH 05/16] scsi_dh_alua: put sense buffer on stack Hannes Reinecke
2013-12-20 12:13 ` [PATCH 06/16] scsi_dh_alua: use local buffer for VPD inquiry Hannes Reinecke
2014-01-17 9:04 ` Mike Christie
2014-01-17 9:38 ` Hannes Reinecke
2013-12-20 12:13 ` [PATCH 07/16] scsi_dh_alua: Use separate alua_port_group structure Hannes Reinecke
2013-12-20 12:13 ` [PATCH 08/16] scsi_dh_alua: parse target device id Hannes Reinecke
2013-12-20 12:13 ` [PATCH 09/16] scsi_dh_alua: simplify sense code handling Hannes Reinecke
2013-12-20 12:13 ` [PATCH 10/16] scsi_dh_alua: Do not attach to management devices Hannes Reinecke
2013-12-20 12:13 ` [PATCH 11/16] scsi_dh_alua: multipath failover fails with error 15 Hannes Reinecke
2013-12-20 12:13 ` [PATCH 12/16] scsi_dh: return individual errors in scsi_dh_activate() Hannes Reinecke
2013-12-20 12:13 ` [PATCH 13/16] scsi_dh_alua: Clarify logging message Hannes Reinecke
2013-12-20 12:13 ` [PATCH 14/16] scsi_dh: invoke callback if ->activate is not present Hannes Reinecke
2013-12-20 12:13 ` [PATCH 15/16] scsi_dh_alua: revert commit a8e5a2d593cbfccf530c3382c2c328d2edaa7b66 Hannes Reinecke
2013-12-20 12:13 ` [PATCH 16/16] scsi_dh_alua: Use workqueue for RTPG Hannes Reinecke
2014-01-21 8:25 ` Vaughan Cao [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-01-31 9:29 [PATCHv2 00/16] scsi_dh_alua updates Hannes Reinecke
2014-01-31 9:30 ` [PATCH 16/16] scsi_dh_alua: Use workqueue for RTPG Hannes Reinecke
2014-02-14 19:03 ` Bart Van Assche
2014-04-29 21:47 ` Stewart, Sean
2014-05-08 7:04 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1390292747-8412-1-git-send-email-vaughan.cao@oracle.com \
--to=vaughan.cao@oracle.com \
--cc=hare@suse.de \
--cc=jbottomley@parallels.com \
--cc=linux-scsi@vger.kernel.org \
--cc=marting@netapp.com \
--cc=sean.stewart@netapp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).