From: Hannes Reinecke <hare@suse.de>
To: James Bottomley <jbottomley@parallels.com>
Cc: Sean Stewart <sean.stewart@netapp.com>,
Martin George <marting@netapp.com>,
linux-scsi@vger.kernel.org, Hannes Reinecke <hare@suse.de>
Subject: [PATCH 09/16] scsi_dh_alua: simplify sense code handling
Date: Fri, 31 Jan 2014 10:29:53 +0100 [thread overview]
Message-ID: <1391160600-19652-10-git-send-email-hare@suse.de> (raw)
In-Reply-To: <1391160600-19652-1-git-send-email-hare@suse.de>
Most sense code is already handled in the generic
code, so we shouldn't be adding special cases here.
However, when doing so we need to check for
unit attention whenever we're sending an internal
command.
Signed-off-by: Hannes Reinecke <hare@suse.de>
---
drivers/scsi/device_handler/scsi_dh_alua.c | 33 +++++-------------------------
1 file changed, 5 insertions(+), 28 deletions(-)
diff --git a/drivers/scsi/device_handler/scsi_dh_alua.c b/drivers/scsi/device_handler/scsi_dh_alua.c
index 857a999..174ff45 100644
--- a/drivers/scsi/device_handler/scsi_dh_alua.c
+++ b/drivers/scsi/device_handler/scsi_dh_alua.c
@@ -388,6 +388,8 @@ static int alua_vpd_inquiry(struct scsi_device *sdev, struct alua_dh_data *h)
goto out;
}
err = alua_check_sense(sdev, &sense_hdr);
+ if (sense_hdr.sense_key == UNIT_ATTENTION)
+ err = ADD_TO_MLQUEUE;
if (err == ADD_TO_MLQUEUE && time_before(jiffies, expiry))
goto retry;
if (err != SUCCESS) {
@@ -617,21 +619,6 @@ static int alua_check_sense(struct scsi_device *sdev,
* LUN Not Accessible - ALUA state transition
*/
return ADD_TO_MLQUEUE;
- if (sense_hdr->asc == 0x04 && sense_hdr->ascq == 0x0b)
- /*
- * LUN Not Accessible -- Target port in standby state
- */
- return SUCCESS;
- if (sense_hdr->asc == 0x04 && sense_hdr->ascq == 0x0c)
- /*
- * LUN Not Accessible -- Target port in unavailable state
- */
- return SUCCESS;
- if (sense_hdr->asc == 0x04 && sense_hdr->ascq == 0x12)
- /*
- * LUN Not Ready -- Offline
- */
- return SUCCESS;
break;
case UNIT_ATTENTION:
if (sense_hdr->asc == 0x29 && sense_hdr->ascq == 0x00)
@@ -646,7 +633,7 @@ static int alua_check_sense(struct scsi_device *sdev,
return ADD_TO_MLQUEUE;
if (sense_hdr->asc == 0x2a && sense_hdr->ascq == 0x01)
/*
- * Mode Parameters Changed
+ * Mode parameter changed
*/
return ADD_TO_MLQUEUE;
if (sense_hdr->asc == 0x2a && sense_hdr->ascq == 0x06)
@@ -659,18 +646,6 @@ static int alua_check_sense(struct scsi_device *sdev,
* Implicit ALUA state transition failed
*/
return ADD_TO_MLQUEUE;
- if (sense_hdr->asc == 0x3f && sense_hdr->ascq == 0x03)
- /*
- * Inquiry data has changed
- */
- return ADD_TO_MLQUEUE;
- if (sense_hdr->asc == 0x3f && sense_hdr->ascq == 0x0e)
- /*
- * REPORTED_LUNS_DATA_HAS_CHANGED is reported
- * when switching controllers on targets like
- * Intel Multi-Flex. We can just retry.
- */
- return ADD_TO_MLQUEUE;
break;
}
@@ -735,6 +710,8 @@ static int alua_rtpg(struct scsi_device *sdev, struct alua_port_group *pg, int w
}
err = alua_check_sense(sdev, &sense_hdr);
+ if (sense_hdr.sense_key == UNIT_ATTENTION)
+ err = ADD_TO_MLQUEUE;
if (err == ADD_TO_MLQUEUE && time_before(jiffies, expiry)) {
sdev_printk(KERN_ERR, sdev, "%s: rtpg retry, ",
ALUA_DH_NAME);
--
1.7.12.4
next prev parent reply other threads:[~2014-01-31 9:30 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-31 9:29 [PATCHv2 00/16] scsi_dh_alua updates Hannes Reinecke
2014-01-31 9:29 ` [PATCH 01/16] scsi_dh_alua: Improve error handling Hannes Reinecke
2014-02-14 11:16 ` Bart Van Assche
2014-02-14 11:32 ` Hannes Reinecke
2014-03-06 23:43 ` Jeremy Linton
2014-03-07 7:12 ` Hannes Reinecke
2014-03-07 15:46 ` Jeremy Linton
2014-01-31 9:29 ` [PATCH 02/16] scsi_dh_alua: use flag for RTPG extended header Hannes Reinecke
2014-01-31 9:29 ` [PATCH 03/16] scsi_dh_alua: Pass buffer as function argument Hannes Reinecke
2014-02-14 11:22 ` Bart Van Assche
2014-02-14 11:36 ` Hannes Reinecke
2014-01-31 9:29 ` [PATCH 04/16] scsi_dh_alua: Make stpg synchronous Hannes Reinecke
2014-02-07 1:24 ` Mike Christie
2014-02-07 1:54 ` Mike Christie
2014-02-12 15:29 ` Hannes Reinecke
2014-02-12 16:11 ` Mike Christie
2014-02-12 16:26 ` Mike Christie
2014-02-12 17:31 ` Mike Christie
2014-02-13 9:31 ` Hannes Reinecke
2014-02-14 11:37 ` Bart Van Assche
2014-02-14 11:53 ` Hannes Reinecke
2014-02-14 18:21 ` Mike Christie
2014-02-19 8:09 ` Hannes Reinecke
2014-02-14 17:17 ` Mike Christie
2014-02-14 11:27 ` Bart Van Assche
2014-02-14 11:38 ` Hannes Reinecke
2014-01-31 9:29 ` [PATCH 05/16] scsi_dh_alua: put sense buffer on stack Hannes Reinecke
2014-01-31 9:29 ` [PATCH 06/16] scsi_dh_alua: use local buffer for VPD inquiry Hannes Reinecke
2014-02-13 9:51 ` Maurizio Lombardi
2014-02-13 10:10 ` Hannes Reinecke
2014-02-14 11:41 ` Bart Van Assche
2014-01-31 9:29 ` [PATCH 07/16] scsi_dh_alua: Use separate alua_port_group structure Hannes Reinecke
2014-02-14 11:56 ` Bart Van Assche
2014-02-14 12:16 ` Hannes Reinecke
2014-02-14 16:12 ` Hannes Reinecke
2014-02-14 17:42 ` Bart Van Assche
2014-01-31 9:29 ` [PATCH 08/16] scsi_dh_alua: parse target device id Hannes Reinecke
2014-02-14 12:09 ` Bart Van Assche
2014-02-14 12:21 ` Hannes Reinecke
2014-02-17 14:05 ` Bart Van Assche
2014-02-17 14:09 ` Hannes Reinecke
2014-02-17 14:27 ` Bart Van Assche
2014-02-17 14:33 ` Hannes Reinecke
2014-02-18 7:26 ` Bart Van Assche
2014-01-31 9:29 ` Hannes Reinecke [this message]
2014-01-31 9:29 ` [PATCH 10/16] scsi_dh_alua: Do not attach to management devices Hannes Reinecke
2014-01-31 9:29 ` [PATCH 11/16] scsi_dh_alua: multipath failover fails with error 15 Hannes Reinecke
2015-03-30 12:30 ` Bart Van Assche
2015-03-30 12:32 ` Hannes Reinecke
2014-01-31 9:29 ` [PATCH 12/16] scsi_dh: return individual errors in scsi_dh_activate() Hannes Reinecke
2014-01-31 9:29 ` [PATCH 13/16] scsi_dh_alua: Clarify logging message Hannes Reinecke
2014-01-31 9:29 ` [PATCH 14/16] scsi_dh: invoke callback if ->activate is not present Hannes Reinecke
2014-01-31 9:29 ` [PATCH 15/16] scsi_dh_alua: revert commit a8e5a2d593cbfccf530c3382c2c328d2edaa7b66 Hannes Reinecke
2014-01-31 9:30 ` [PATCH 16/16] scsi_dh_alua: Use workqueue for RTPG Hannes Reinecke
2014-02-14 19:03 ` Bart Van Assche
2014-04-29 21:47 ` Stewart, Sean
2014-05-08 7:04 ` Hannes Reinecke
2014-03-02 9:10 ` [PATCHv2 00/16] scsi_dh_alua updates Bart Van Assche
-- strict thread matches above, loose matches on Subject: below --
2013-12-20 12:13 [PATCH " Hannes Reinecke
2013-12-20 12:13 ` [PATCH 09/16] scsi_dh_alua: simplify sense code handling Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1391160600-19652-10-git-send-email-hare@suse.de \
--to=hare@suse.de \
--cc=jbottomley@parallels.com \
--cc=linux-scsi@vger.kernel.org \
--cc=marting@netapp.com \
--cc=sean.stewart@netapp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).